Repository navigation
chore: require PHP 8.5 and apply Rector PHP 8.5 rules - #71
Merged
Merged
Conversation
Rector changes are syntax only: new without parentheses and #[\Override] on overridden properties.
Base automatically changed from
feature/docker-compose-template-update
to
develop
November 8, 2026 20:18
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #71 +/- ##
==========================================
Coverage 74.39% 74.39%
Complexity 264 264
==========================================
Files 30 30
Lines 738 738
==========================================
Hits 549 549
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require PHP 8.5 and apply the Rector PHP 8.5 rules.
This PR depends on #70 (PHP 8.5 image). The base branch is
feature/docker-compose-template-update. After #70 is merged, change the base todevelop.Changes
>=8.5incomposer.json, the same asevent-database-imports. Runcomposer update --lock.withPhpSets()reads the PHP version fromcomposer.json):NewMethodCallWithoutParenthesesRector:(new Foo())->bar()becomesnew Foo()->bar()(PHP 8.4 syntax).AddOverrideAttributeToOverriddenPropertiesRector:#[\Override]on properties that override a parent property (PHP 8.5). These are mostly the static props in the tests that overrideAbstractApiTestCase.CLAUDE.mdand in the comment inrector.php.Why
The application runs on PHP 8.5 after #70. The requirement in
composer.jsonmust agree with the runtime.The
#[\Override]attribute is not required by PHP 8.5. It makes PHP stop with an error when a parent property is renamed or removed. Without the attribute, the child property silently becomes a new property.The changes are in a separate PR, because
#[\Override]on a property causes an error on PHP 8.4.Checks