Repository navigation
chore: update Elasticsearch image and remove unused RabbitMQ - #72
Merged
Merged
Conversation
Elasticsearch 8.19.23 is the same version as in event-database-imports. The API does not use RabbitMQ (no messenger or amqp).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #72 +/- ##
==========================================
Coverage 74.39% 74.39%
Complexity 264 264
==========================================
Files 30 30
Lines 738 738
==========================================
Hits 549 549
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the images that the ITK Dev template does not control. This is step 2 of the quarterly update.
Changes
elasticsearchfrom8.19.18to8.19.23indocker-compose.override.yml. This is the latest 8.19 patch, and the same version as inevent-database-imports.rabbitservice (rabbitmq:3.12.4-management-alpine) and thedepends_onofphpfpmfromdocker-compose.override.yml.rabbitfrom the comments inpr.yamlandapi-spec.yml.No change for these images:
itkdev/markdownlintandjauderho/prettierhave no tag (latest).itkdev/ansible-plugin:1in.woodpecker/uses a major-version tag.Why
The API does not use RabbitMQ. There is no Messenger or AMQP configuration, and no code uses it. An update from 3.12 to 4 would update a service that nothing uses, so this PR removes the service.
The
elasticsearchservice is only for development and tests. Production uses the shared Elasticsearch cluster.Checks
After the merge
docker compose up --detach --wait --remove-orphanslocally, to remove the oldrabbitcontainer.