Repository navigation
chore: update Rector and PHPStan and apply new Rector rules - #75
Merged
Merged
Conversation
Rector 2.8 adds ParamAndEnvAttributeRector and DirnameDirConcatStringToDirectStringPathRector. Both changes are equivalent code. The PHPStan baseline does not change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #75 +/- ##
==========================================
Coverage 74.39% 74.39%
Complexity 264 264
==========================================
Files 30 30
Lines 738 738
==========================================
Hits 549 549
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Rector and PHPStan, and apply the new Rector rules. This is step 5 of the quarterly update.
Changes
rector/rector2.5.4 → 2.8.3phpstan/phpstan2.2.5 → 2.3.4phpstan/phpstan-strict-rules2.0.11 → 2.1.0phpstan/phpstan-symfony2.0.20 → 2.1.1ParamAndEnvAttributeRectorinsrc/Command/ApiKeysAddCommand.php:#[Autowire('%kernel.project_dir%')]becomes#[Autowire(param: 'kernel.project_dir')].DirnameDirConcatStringToDirectStringPathRectorintests/bootstrap.php:dirname(__DIR__).'/vendor/autoload.php'becomes__DIR__.'/../vendor/autoload.php'. The same change applies to.env.Why
The quarterly update keeps Rector and PHPStan current. New rules change code, so this update is in a separate PR from the dependency update (#74).
PHPStan 2.3 finds no new errors. I generated the baseline again, and it did not change (9 entries).
rector.phphas nowithSkip(), so there are no unknown rules to remove.Checks
bin/console lint:container: no errors (for theAutowirechange).