Repository navigation
chore: update Symfony Flex recipes - #77
Merged
Merged
Conversation
Keep the ITK Dev .php-cs-fixer.dist.php. It already excludes config/reference.php, which is the only change in the recipe.
debug:router output is unchanged.
Keep the project api_user_provider.
Do not add the FrankenPHP hot-reload block to templates/base.html.twig. The project uses php-fpm.
PHPStan strict rules do not allow the short ternary from the framework-bundle recipe.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #77 +/- ##
==========================================
Coverage 74.39% 74.39%
Complexity 264 264
==========================================
Files 30 30
Lines 738 738
==========================================
Hits 549 549
Misses 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Use the same pattern as APP_PROJECT_URI.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the 8 outdated Symfony Flex recipes, one commit for each recipe. This is step 7 of the quarterly update.
Changes
doctrine/deprecations: only the recipe reference insymfony.lock.friendsofphp/php-cs-fixer: only the recipe reference. Keep the ITK Dev.php-cs-fixer.dist.php. It already excludesconfig/reference.php, which is the only change in the recipe.phpunit/phpunit: simplifybin/phpunit. Thedate.timezonedefault is removed. PHP 8 uses UTC when no time zone is set.phpunit.dist.xmldoes not change.symfony/framework-bundle:APP_SHARE_DIR=var/shareto.env(the Symfony 7.4 share directory).config/preload.phploads allvar/cache/prod/*.preload.phpfiles.config/services.yaml: comments and a schema line only.public/index.php:staticclosure.symfony/routing:default_uricomes from the newDEFAULT_URIvariable. Before, it was a comment. This affects only URLs that CLI commands generate. In.env,DEFAULT_URI=https://${COMPOSE_DOMAIN}, the same pattern asAPP_PROJECT_URI, instead of the recipe defaulthttp://localhost.config/routes.yamlloads the controllers with therouting.controllersresource (Symfony 7.4).symfony/security-bundle: keep the projectapi_user_provider. Thedevfirewall pattern changes to^/(_profiler(/|$)|(_wdt|assets|build)/). The other changes are comments.symfony/twig-bundle: only the recipe reference. Do not add the FrankenPHP hot-reload block totemplates/base.html.twig, because the project uses php-fpm.vincentlanglet/twig-cs-fixer: ignore a local/.twig-cs-fixer.phpin.gitignore.config/preload.phpto a long ternary, because PHPStan strict rules do not allow it.Why
The quarterly update keeps the recipes current.
composer recipes --outdatednow reports no outdated recipes.The routes and the services must not change:
bin/console debug:router: the output is the same before and after.bin/console debug:container --env=prod: only 2 internal.security.request_matcher.*IDs change. Their names are hashes of the firewall pattern, and thedevfirewall pattern changed.bin/console lint:container: no errors.Checks
config/): no changes.After the deploy
.envhas new defaults forAPP_SHARE_DIRandDEFAULT_URI.DEFAULT_URIusesCOMPOSE_DOMAIN, the same asAPP_PROJECT_URI. The server.env.localdoes not need a change ifAPP_PROJECT_URIis already correct there.