Skip to content

fix(menger): restore prepared atlas binding #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alowpoly wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(menger): restore prepared atlas binding #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/adapters/menger/prepared-bank.lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,15 @@
{
"schema": "cssmenger-prepared-bank-lock@1",
"tag": "cssmenger-product-bank-v15",
"asset": "cssmenger-product-bank-v15.tar.gz",
"url": "https://github.com/layoutit/cssGraphics/releases/download/cssmenger-product-bank-v15/cssmenger-product-bank-v15.tar.gz",
"archiveByteLength": 17111113,
"archiveSha256": "56c730a1a8b7644f0549b5806cb8bf931624bb07f541cf58c7853cf1f04d442d",
"productClosureBytes": 19928383,
"productClosureSha256": "b2ba1fdc0013799a7290254fde4bbbc570e18c05ea2a203831c49cd4e6d236e9",
"tag": "cssmenger-product-bank-v16",
"asset": "cssmenger-product-bank-v16.tar.gz",
"url": "https://github.com/layoutit/cssGraphics/releases/download/cssmenger-product-bank-v16/cssmenger-product-bank-v16.tar.gz",
"archiveByteLength": 17111158,
"archiveSha256": "c3c9856e134a0e70af92746fadcee3827515c828f03e2ef44cd466911f05e7c9",
"productClosureBytes": 19928583,
"productClosureSha256": "d717e6fb3a4c48b40c10e6855e3b517564099bf30f03012ae96ea487899acdf5",
"productFileCount": 13,
"productDescriptorByteLength": 1538,
"productDescriptorSha256": "1de9d2219362fa21baa4a2cb500593130a6519069d0c256348969dda740be53b",
"productDescriptorSha256": "f0fe40972f116799743f4e1858d49e924c8dd960d4235d1389be09aa65f0e9a3",
"sceneCount": 2,
"retainedRenderWrapperCount": 2,
"retainedModelRootCount": 0,
Expand Down
4 changes: 4 additions & 0 deletions src/adapters/menger/tools/productBank.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ export async function inspectCssmengerProductBank(root, { verifyDescriptor = tru
/matrix3d\(12\.222222222,/u.test(snapshot) &&
count(snapshot, /<b><\/b>/gu) === 0 &&
!/\.polycss-scene>b:nth-child\(\d+\)\{transform:/u.test(snapshot) &&
count(snapshot, /:is\(body,\.example-stage\)>\.polycss-camera>\.polycss-scene/gu) === 5 &&
!snapshot.includes("body>.polycss-camera>.polycss-scene") &&
/\.polycss-scene>b\{background-image:url\("\/cssmenger\/assets\/lighting-grid-[a-f0-9]{64}\.webp"\)\}/u.test(snapshot) &&
/\.polycss-scene\.cssmenger-mobile-atlas.*lighting-grid-mobile-[a-f0-9]{64}\.webp/u.test(snapshot) &&
snapshot.includes(scene.cssOpacityBaseAtlas.assetUrl) &&
Expand Down Expand Up @@ -252,6 +254,8 @@ export async function inspectCssmengerProductBank(root, { verifyDescriptor = tru
count(reducedSnapshot, /<b style="transform: matrix3d\(/gu) === 30 &&
/matrix3d\(36\.666666667,/u.test(reducedSnapshot) &&
/--cssmenger-tile-width:9px;--cssmenger-tile-height:9px/u.test(reducedSnapshot) &&
count(reducedSnapshot, /:is\(body,\.example-stage\)>\.polycss-camera>\.polycss-scene/gu) === 5 &&
!reducedSnapshot.includes("body>.polycss-camera>.polycss-scene") &&
reducedSnapshot.includes(reducedScene.cssOpacityBaseAtlas.assetUrl) &&
reducedSnapshot.includes(reducedScene.cssOpacityShadowAtlas.assetUrl) &&
count(reducedSnapshot, /%\{transform:rotateX/gu) === 1_537 &&
Expand Down
4 changes: 3 additions & 1 deletion src/adapters/menger/tools/smoke-browser.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ try {
const importantRules = [];
for (const sheet of [...document.styleSheets]) {
for (const rule of [...(sheet.cssRules ?? [])]) {
if (rule.cssText?.includes("!important")) importantRules.push(rule.cssText);
if (rule.cssText?.includes("!important") && rule.cssText.includes("polycss-")) {
importantRules.push(rule.cssText);
}
}
}
const firstStyle = getComputedStyle(leaves[0]);
Expand Down