Retry LK CLI installs in CI - #248
Open
alan-george-lk wants to merge 2 commits into
Open
Conversation
alan-george-lk
marked this pull request as ready for review
September 1, 2026 17:07
alan-george-lk
requested review from
a team and
xianshijing-lk
as code owners
September 1, 2026 17:07
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| retry_delay_seconds=3 | ||
| if [[ "$RUNNER_OS" == "Linux" ]]; then | ||
| curl -sSL https://get.livekit.io/cli | bash | ||
| curl -sSL --retry "$retry_count" --retry-delay "$retry_delay_seconds" https://get.livekit.io/cli | bash |
Contributor
There was a problem hiding this comment.
🟡 Linux installation failures remain unretried
On Linux, curl --retry retries only the installer-script download, while any failure inside the downloaded installer ends the job immediately.
Suggested change
| curl -sSL --retry "$retry_count" --retry-delay "$retry_delay_seconds" https://get.livekit.io/cli | bash | |
| for attempt in $(seq 0 "$retry_count"); do | |
| if curl -sSL --retry "$retry_count" --retry-delay "$retry_delay_seconds" https://get.livekit.io/cli | bash; then | |
| break | |
| fi | |
| if [[ "$attempt" == "$retry_count" ]]; then | |
| exit 1 | |
| fi | |
| sleep "$retry_delay_seconds" | |
| done |
Was this helpful? React with 👍 or 👎 to provide feedback.
| curl -sSL --retry "$retry_count" --retry-delay "$retry_delay_seconds" https://get.livekit.io/cli | bash | ||
| elif [[ "$RUNNER_OS" == "macOS" ]]; then | ||
| brew install livekit-cli | ||
| for attempt in $(seq 0 "$retry_count"); do |
Collaborator
There was a problem hiding this comment.
brew already tried to install 3 times, so i dont think we need this chunk
| --repo livekit/livekit-cli \ | ||
| --pattern "*_windows_amd64.zip" \ | ||
| --output "$RUNNER_TEMP/lk.zip" | ||
| for attempt in $(seq 0 "$retry_count"); do |
Collaborator
There was a problem hiding this comment.
why arent we using winget here?
https://github.com/livekit/livekit-cli#windows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent flaky tests (specifically nightly) around failing to install LK CLI.