Retry LK CLI installs in CI #248
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -366,18 +366,38 @@ jobs: | |
| GH_TOKEN: ${{ github.token }} | ||
| run: | | ||
| set -euxo pipefail | ||
| # Change these to change the retry count and delay across all OS entries | ||
| retry_count=3 | ||
| retry_delay_seconds=3 | ||
| if [[ "$RUNNER_OS" == "Linux" ]]; then | ||
| curl -sSL --retry "$retry_count" --retry-delay "$retry_delay_seconds" https://get.livekit.io/cli | bash | ||
| elif [[ "$RUNNER_OS" == "macOS" ]]; then | ||
| for attempt in $(seq 0 "$retry_count"); do | ||
|
Collaborator
There was a problem hiding this comment. brew already tried to install 3 times, so i dont think we need this chunk |
||
| if brew install livekit-cli; then | ||
| break | ||
| fi | ||
| if [[ "$attempt" == "$retry_count" ]]; then | ||
| exit 1 | ||
| fi | ||
| sleep "$retry_delay_seconds" | ||
| done | ||
| elif [[ "$RUNNER_OS" == "Windows" ]]; then | ||
| install_dir="$RUNNER_TEMP/livekit-cli" | ||
| mkdir -p "$install_dir" | ||
| for attempt in $(seq 0 "$retry_count"); do | ||
|
Collaborator
There was a problem hiding this comment. why arent we using winget here? |
||
| if tag="$(gh api repos/livekit/livekit-cli/releases/latest --jq '.tag_name')" && \ | ||
| gh release download "$tag" \ | ||
| --repo livekit/livekit-cli \ | ||
| --pattern "*_windows_amd64.zip" \ | ||
| --output "$RUNNER_TEMP/lk.zip"; then | ||
| break | ||
| fi | ||
| if [[ "$attempt" == "$retry_count" ]]; then | ||
| exit 1 | ||
| fi | ||
| rm -f "$RUNNER_TEMP/lk.zip" | ||
| sleep "$retry_delay_seconds" | ||
| done | ||
| unzip -o "$RUNNER_TEMP/lk.zip" -d "$install_dir" | ||
| # GITHUB_PATH updates apply to subsequent steps only; export PATH here | ||
| # so lk --version in this step succeeds. | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Linux installation failures remain unretried
On Linux,
curl --retryretries only the installer-script download, while any failure inside the downloaded installer ends the job immediately.Was this helpful? React with 👍 or 👎 to provide feedback.