Skip to content

Fix Statistics hang on daylight saving fall-back days - #795

Merged
bjorkert merged 1 commit into
devfrom
fix/stats-dst-day-step
Oct 27, 2026
Merged

bjorkert merged 1 commit into
devfrom
fix/stats-dst-day-step

Conversation

@bjorkert

@bjorkert bjorkert commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Opening Statistics hung and was eventually killed when the selected period contained a day where the clock goes back an hour (25 October 2026 in Europe, 1 November 2026 in the US). The basal gap and temp basal adjustment loops advanced from the start of a day by a fixed 24 hours, which on a 25-hour day lands at 23:00 on the same date, so the loop never progressed and the gap loop kept appending entries. Both loops now step to the next day with the calendar.

@codebymini codebymini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjorkert
bjorkert merged commit 9de3e2f into dev Oct 27, 2026
2 checks passed
@bjorkert
bjorkert deleted the fix/stats-dst-day-step branch October 27, 2026 18:40
kristinkand added a commit to kristinkand/LoopFollow that referenced this pull request Oct 29, 2026
The watch app, its project entries and Fastfile follow dev's final loopandlearn#785, which is newer
than the test/watch-785 branch merged before. The hub's background refresh logic stays;
only the Bluetooth heartbeat's Silent Tune fallback leaves it, as on Integration. The
statistics fix is Integration's, which also steps by calendar day (loopandlearn#795).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01UUzqfqfsM8BQYJ2yoRaLz8
akoi added a commit to akoi/LoopFollow that referenced this pull request Oct 30, 2026
Adapt upstream LoopFollow PR loopandlearn#795 to a shared calendar-day helper.
Preserves local Xcode 27.1 app icon fix and adds Europe/Stockholm DST tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants