Repository navigation
feat(lanes): pass the transcript key to the reusable review and intake legs - #12579
Conversation
…e legs The model legs inside ci-workflows' pr-review-cli.yml and intake-triage.yml seal and upload their transcripts only when a caller passes the key, so these three callers kept none. A test now holds every such caller to passing it. Refs: #7676 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VQb9Q1VgLEiwGgRVshK3b7
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no security issues foundI read every hunk of all 4 changed files. Two of them are trusted paths: What changed. Three calls to reusable workflows in ci-workflows now pass one new input,
A new test checks that every caller of those two reusables passes the key. Checks I ran:
Spend: the three newly enabled legs upload more sealed transcript artifacts, which uses Actions artifact storage. This is a small addition to the more than 13 legs that already do the same, and it is not a billing setting or a paid plan. critical-findings: 0 |
|
claude-review reviewed Code review: no findingsI read every hunk of all 4 changed files. What changed
What I checked
Author's claims I did not verify: the Closing issue: the PR only says Spend: the code and security review runs, and intake runs, will now upload sealed transcript artifacts. That is a little more Actions artifact storage, the same kind the repo's other model legs already upload. It costs nothing unless the repository goes over its included artifact storage. I did not set a hold for it. No instructions were embedded in the PR context or prior-findings files. |
Refs: #7676
Summary
The model legs inside ci-workflows'
pr-review-cli.ymlandintake-triage.ymlcan now seal and upload their transcripts (ci-workflows#969), but only when the caller passes the key. These three callers pass none, so those legs print a skip notice and keep nothing. After this PR the daily puller has their transcripts to copy.Fix
intake-triage.yml,pr-review-hosted.ymlandpr-review-security-hosted.ymlpasslane-transcript-public-key: ${{ vars.LANE_TRANSCRIPT_PUBLIC_KEY }}. The runner policy already allows the input (standards#942, synced by chore: sync standards components #12571).callers.test.mjsholds every caller of those two reusables to passing the key, since the existing coverage test sees only steps in this repository's own workflows.A sealing failure cannot change a lane's outcome: the reusable's upload steps are
continue-on-error, and a credential hit in the plaintext seals nothing.Verification
node --test --test-name-pattern=transcript .github/actions/resolve-config/callers.test.mjs: 2/2 pass.node .github/standards/runner-policy/runner-policy.mjs --root <worktree>: "Runner policy passed."actionlinton the three workflows: only thecache-modeerrors atintake-triage.yml:723and:1073, on lines this PR does not touch.Related
Remaining
lane-transcript-code-review-*orlane-transcript-security-review-*on a run, thenpull.mjsstoring it withsealed_mismatch0.🤖 Generated with Claude Code
https://claude.ai/code/session_01VQb9Q1VgLEiwGgRVshK3b7