Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/actions/resolve-config/callers.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7536,6 +7536,18 @@ test("every model leg is followed by a sealed transcript upload of its own execu
assert.ok(legs >= 13, `only ${legs} model legs found`);
});

test("every caller of a reusable holding model legs passes the transcript key", () => {
let callers = 0;
for (const file of workflowFiles()) {
for (const [jobId, job] of Object.entries(workflow(file).jobs ?? {})) {
if (!/\/ci-workflows\/\.github\/workflows\/(pr-review-cli|intake-triage)\.yml@/.test(String(job.uses ?? ""))) continue;
callers++;
assert.equal(job.with?.["lane-transcript-public-key"], "${{ vars.LANE_TRANSCRIPT_PUBLIC_KEY }}", `${file}#${jobId}`);
}
}
assert.ok(callers >= 3, `only ${callers} callers found`);
});

// request-lane-token's kill-switch-ok ends a kill-switch refusal green with no
// token, so nothing after it may run on success() alone: every later step is
// gated, a step that reads the token runs only when it is set, and a job that
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/intake-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ jobs:
runner: ubuntu-24.04
role: intake
claude-args: ${{ needs.born-triaged.outputs.claude-args }}
lane-transcript-public-key: ${{ vars.LANE_TRANSCRIPT_PUBLIC_KEY }}
issue-number: ${{ inputs.issue-number }}
allowed-author-ids: ${{ needs.born-triaged.outputs.human-ids }}
allowed-bot-sender-ids: ${{ needs.born-triaged.outputs.bot-ids }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr-review-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,7 @@ jobs:
with:
lane: code
publish: comments
lane-transcript-public-key: ${{ vars.LANE_TRANSCRIPT_PUBLIC_KEY }}
# Empty unless resolve-model succeeded, so a failed job's partial output
# never reaches the review.
model-args: ${{ needs.resolve-model.result == 'success' && needs.resolve-model.outputs.claude-args || '' }}
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/pr-review-security-hosted.yml
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,7 @@ jobs:
with:
lane: security
publish: comments
lane-transcript-public-key: ${{ vars.LANE_TRANSCRIPT_PUBLIC_KEY }}
# Empty unless resolve-model succeeded, so a failed job's partial output
# never reaches the review.
model-args: ${{ needs.resolve-model.result == 'success' && needs.resolve-model.outputs.claude-args || '' }}
Expand Down
Loading