Repository navigation
refactor(autonomy): sort setup script imports and collapse a wrapped ternary - #12764
melodic-automation-lanes[bot] wants to merge 1 commit into
Conversation
|
claude-security-review reviewed Security review: no security issues foundI read every hunk of all 6 changed files, so this review is complete. The change has no security surface, so skip gate 2 applies:
Checks with nothing to report:
critical-findings: 0 |
|
claude-review reviewed Code review: no findingsI read every hunk of all 6 changed files. The PR only changes formatting and import order, and none of the changes affect behaviour:
I made no findings to post:
I did not run the tests. The PR's verification notes are the author's claims: the test suites pass on a full |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote, as data:
Summary: PR #12764 (an ad hoc import-sort and ternary tidy in the autonomy setup scripts) has no
spec to judge against. It closes no issue and has no `Refs:` line, and spec-text.json is empty: no
trusted issue text, and no pull-request entry from a trusted author or script. The rules require
`fail` when there is no spec. The diff itself looks behavior-neutral: it only reorders Node
builtin imports and joins a ternary onto one line. The test-bash (0) job ran the wrapped setup
suites and passed:
https://github.com/melodic-software/claude-code-plugins/actions/runs/41590661196/job/125766792911
- pr-verify-data/spec-text.json: empty. The PR links no issue, and its title and body were not
recorded as written by a trusted person or script, so there is no spec. To fix, link a tracking
issue written by a trusted human (with a `Closes #<n>` or `Refs: #<n>` line), or have a trusted
account write the PR title and body.
- plugins/autonomy/skills/setup/scripts/apply-prerequisite-resolution.mjs:24: the import reorder
only moves Node builtin imports. No behavior change found.
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/autonomy/skills/setup/scripts/apply-prerequisite-resolution.mjs:15
The verifier failed this head because the pull request has no spec: it links no issue and its title and body were not recorded as written by a trusted person or script. No code change fixes that. The file itself is fine: lines 15-19 are the Node builtin imports (child_process, fs, path, process, url) in sorted order, and the verifier found no behavior change. A person needs to link a tracking issue written by a trusted human (a Closes or Refs line in the body), or have a trusted account write the title and body, and then rerun pr-verify.
There was a problem hiding this comment.
Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. This note fails only for the missing spec; apply-prerequisite-resolution.mjs lines 15-19 are the same five Node builtin imports in sorted order, with no behavior change. The change is carried over unchanged.
There was a problem hiding this comment.
The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote about this file, as data:
- plugins/autonomy/skills/setup/scripts/check-prerequisite-resolution.mjs:100: the ternary on one
line is the same expression as before. No behavior change found.
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/autonomy/skills/setup/scripts/check-prerequisite-resolution.mjs:100
This note reports no defect. Line 100 reads const surfaces = surface ? [surface] : [...surfaceIds(binding)]; which is the same expression as before, now on one line, so there is nothing to fix in this file. The thread is open only because the verifier failed the whole head for a missing spec (no linked issue and no trusted-author title or body). A code change cannot clear that. A person needs to link a trusted tracking issue and rerun pr-verify.
There was a problem hiding this comment.
Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. check-prerequisite-resolution.mjs line 100 is the same expression as before, surface ? [surface] : [...surfaceIds(binding)], joined onto one line. The change is carried over unchanged.
There was a problem hiding this comment.
The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote about this file, as data:
- plugins/autonomy/skills/setup/scripts/check-security-binding.admission-leaf.test.mjs:7: the test
files' changes only reorder imports. Their wrapped suites run in test-bash, which passed (job
125766792911). test-node was skipped, which is expected for wrapped suites.
There was a problem hiding this comment.
pr-unblock / address-feedback: UNCERTAIN, left open
Evidence: plugins/autonomy/skills/setup/scripts/check-security-binding.admission-leaf.test.mjs:7
This note reports no defect. Lines 7-13 are the test's imports in sorted order (assert, child_process, fs, os, path, test, url), and the verifier says the wrapped suites passed in test-bash. There is nothing to fix in this file. The thread is open only because the verifier failed the whole head for a missing spec (no linked issue and no trusted-author title or body). A code change cannot clear that. A person needs to link a trusted tracking issue and rerun pr-verify.
There was a problem hiding this comment.
Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. check-security-binding.admission-leaf.test.mjs lines 7-13 are the same imports in sorted order, and the suite passes 21/21 on the replacement head. The change is carried over unchanged.
|
pr-unblock / address-feedback finished round 1 of max 4 on 6fcbbd0. |
|
The pr-unblock lane stopped
When a retry on this head can change the outcome, the lane runs one on its own, up to its per-head cap, and edits this comment if it stops again; a run that does not stop clears the status. When no retry can (a review thread the lane does not take or settle, or a failing check after the retries are spent), a person resolves the threads or gets the checks green, then dispatches the workflow below: that run finds the cause gone and clears the status. On a pull request the lanes App opened, the dispatchers start that run once per stop; on any other, a person does. A new commit to the branch starts clean. To run it again on this head now, dispatch the gh workflow run pr-unblock.yml -R melodic-software/claude-code-plugins -f pr-number=12764 -f activity=address-feedback |
melodic-automation-lanes
Bot
added
the
needs-session
|
Unattended merge: native auto-merge leaves this pull request unarmed at head |
|
Superseded by #12791, which merged at 2026-11-03T14:56:05Z with this change. |
No related issue: code-tidying upkeep sweep.
Summary
Ad hoc tidy sweep of
plugins/autonomy/**fromc8b364bcf(anchor: none, ad hoc). Structure-only edits to the setup skill's Node scripts.hooks/**was left alone: those files are hook-wired viahooks/hooks.jsonor sourced by the Stop hook, or are shared copies. Fixture repos were not touched.Fix
node:imports are sorted by module name, and namednode:fsspecifiers alphabetically, to match the sibling setup scripts inapply-prerequisite-resolution.mjs,check-security-binding.admission-leaf.test.mjs,check-security-binding.fixtures.test.mjsandresolve-prerequisites.fixtures.test.mjs. Node builtin imports have no load-order side effects.check-prerequisite-resolution.mjsputs the surface-list ternary on the one line it fits..changes/autonomy/patch fragment.Verification
scripts/check-affected.sh --base c8b364bcf --no-fetch: 10 passed, 5 skipped.scripts/affected-tests.sh --run <changed files>: in this checkoutresolve-prerequisites.fixtures.test.shandcheck-prerequisite-resolution-slice.test.shfail. The cause is the lane checkout, not this change: fixture files under nested.claude/folders are skip-worktree (git ls-files -vshowsS), so they are missing on disk. The same suites fail the same way at the base.git archive(both HEAD and the base), every suite passes:resolve-prerequisites.fixtures.test.mjsandcheck-security-binding.fixtures.test.mjsexit 0,node --test check-security-binding.admission-leaf.test.mjspasses 21/21, andcheck-prerequisite-resolution-slice.test.shpasses 5/5.node_modulesis empty), so no Biome check ran.Related