Skip to content

refactor(autonomy): sort setup script imports and collapse a wrapped ternary #12764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
melodic-automation-lanes wants to merge 1 commit into from
Closed

refactor(autonomy): sort setup script imports and collapse a wrapped ternary #12764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/autonomy/chore-tidy-adhoc-plugins-autonomy-2026-11-03-8346b003.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Changed

- Sorted the setup scripts' node: imports and collapsed a wrapped ternary in check-prerequisite-resolution.mjs; no behavior change.
4 changes: 2 additions & 2 deletions plugins/autonomy/skills/setup/scripts/apply-prerequisite-resolution.mjs
View file
Open in desktop

@github-actions github-actions Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote, as data:

Summary: PR #12764 (an ad hoc import-sort and ternary tidy in the autonomy setup scripts) has no
  spec to judge against. It closes no issue and has no `Refs:` line, and spec-text.json is empty: no
  trusted issue text, and no pull-request entry from a trusted author or script. The rules require
  `fail` when there is no spec. The diff itself looks behavior-neutral: it only reorders Node
  builtin imports and joins a ternary onto one line. The test-bash (0) job ran the wrapped setup
  suites and passed:
  https://github.com/melodic-software/claude-code-plugins/actions/runs/41590661196/job/125766792911
- pr-verify-data/spec-text.json: empty. The PR links no issue, and its title and body were not
  recorded as written by a trusted person or script, so there is no spec. To fix, link a tracking
  issue written by a trusted human (with a `Closes #<n>` or `Refs: #<n>` line), or have a trusted
  account write the PR title and body.
- plugins/autonomy/skills/setup/scripts/apply-prerequisite-resolution.mjs:24: the import reorder
  only moves Node builtin imports. No behavior change found.

@melodic-automation-lanes melodic-automation-lanes Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/autonomy/skills/setup/scripts/apply-prerequisite-resolution.mjs:15

The verifier failed this head because the pull request has no spec: it links no issue and its title and body were not recorded as written by a trusted person or script. No code change fixes that. The file itself is fine: lines 15-19 are the Node builtin imports (child_process, fs, path, process, url) in sorted order, and the verifier found no behavior change. A person needs to link a tracking issue written by a trusted human (a Closes or Refs line in the body), or have a trusted account write the title and body, and then rerun pr-verify.

@kyle-sexton kyle-sexton Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. This note fails only for the missing spec; apply-prerequisite-resolution.mjs lines 15-19 are the same five Node builtin imports in sorted order, with no behavior change. The change is carried over unchanged.

Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@
// node apply-prerequisite-resolution.mjs --repo <dir> --ratify --proposal <file>
// Exit 0 = report / write ok; 1 = failure.

import { readFileSync, writeFileSync, mkdirSync, statSync } from "node:fs";
import { dirname, join } from "node:path";
import { spawnSync } from "node:child_process";
import { mkdirSync, readFileSync, statSync, writeFileSync } from "node:fs";
import { dirname, join } from "node:path";
import process from "node:process";
import { fileURLToPath } from "node:url";

Expand Down
4 changes: 1 addition & 3 deletions plugins/autonomy/skills/setup/scripts/check-prerequisite-resolution.mjs
View file
Open in desktop

@github-actions github-actions Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote about this file, as data:

- plugins/autonomy/skills/setup/scripts/check-prerequisite-resolution.mjs:100: the ternary on one
  line is the same expression as before. No behavior change found.

@melodic-automation-lanes melodic-automation-lanes Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/autonomy/skills/setup/scripts/check-prerequisite-resolution.mjs:100

This note reports no defect. Line 100 reads const surfaces = surface ? [surface] : [...surfaceIds(binding)]; which is the same expression as before, now on one line, so there is nothing to fix in this file. The thread is open only because the verifier failed the whole head for a missing spec (no linked issue and no trusted-author title or body). A code change cannot clear that. A person needs to link a trusted tracking issue and rerun pr-verify.

@kyle-sexton kyle-sexton Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. check-prerequisite-resolution.mjs line 100 is the same expression as before, surface ? [surface] : [...surfaceIds(binding)], joined onto one line. The change is carried over unchanged.

Original file line number Diff line number Diff line change
Expand Up @@ -97,9 +97,7 @@ function main() {
}

const binding = loadBinding(repo);
const surfaces = surface
? [surface]
: [...surfaceIds(binding)];
const surfaces = surface ? [surface] : [...surfaceIds(binding)];
if (surfaces.length === 0) surfaces.push("unbound");

const reports = [];
Expand Down
2 changes: 1 addition & 1 deletion plugins/autonomy/skills/setup/scripts/check-security-binding.admission-leaf.test.mjs
View file
Open in desktop

@github-actions github-actions Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr-verify verifier failed head 6fcbbd0c239c0f5697233e115b85f73e86b18f40. What it wrote about this file, as data:

- plugins/autonomy/skills/setup/scripts/check-security-binding.admission-leaf.test.mjs:7: the test
  files' changes only reorder imports. Their wrapped suites run in test-bash, which passed (job
  125766792911). test-node was skipped, which is expected for wrapped suites.

@melodic-automation-lanes melodic-automation-lanes Bot Nov 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr-unblock / address-feedback: UNCERTAIN, left open

Evidence: plugins/autonomy/skills/setup/scripts/check-security-binding.admission-leaf.test.mjs:7

This note reports no defect. Lines 7-13 are the test's imports in sorted order (assert, child_process, fs, os, path, test, url), and the verifier says the wrapped suites passed in test-bash. There is nothing to fix in this file. The thread is open only because the verifier failed the whole head for a missing spec (no linked issue and no trusted-author title or body). A code change cannot clear that. A person needs to link a trusted tracking issue and rerun pr-verify.

@kyle-sexton kyle-sexton Nov 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replaced by #12791, opened under the owner login so its title and body give pr-verify a trusted spec. Outcome: not a defect. check-security-binding.admission-leaf.test.mjs lines 7-13 are the same imports in sorted order, and the suite passes 21/21 on the replacement head. The change is carried over unchanged.

Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,12 @@
// autonomous-eligible rule per cell: the checker must reject the rule exactly
// where the leaf ships a less permissive disposition for that cell.

import assert from "node:assert/strict";
import { spawnSync } from "node:child_process";
import { mkdtempSync, readFileSync, rmSync, writeFileSync } from "node:fs";
import { tmpdir } from "node:os";
import { dirname, join, resolve } from "node:path";
import test from "node:test";
import assert from "node:assert/strict";
import { fileURLToPath } from "node:url";

const scriptsDir = dirname(fileURLToPath(import.meta.url));
Expand Down
2 changes: 1 addition & 1 deletion plugins/autonomy/skills/setup/scripts/check-security-binding.fixtures.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
import { spawnSync } from "node:child_process";
import { existsSync, readdirSync, readFileSync } from "node:fs";
import { dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import process from "node:process";
import { fileURLToPath } from "node:url";
import { createFixtureHarness } from "./fixture-harness.mjs";

const scriptsDir = dirname(fileURLToPath(import.meta.url));
Expand Down
2 changes: 1 addition & 1 deletion plugins/autonomy/skills/setup/scripts/resolve-prerequisites.fixtures.test.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
import { spawnSync } from "node:child_process";
import { readdirSync, readFileSync, statSync } from "node:fs";
import { dirname, join, resolve } from "node:path";
import { fileURLToPath } from "node:url";
import process from "node:process";
import { fileURLToPath } from "node:url";
import { createFixtureHarness } from "./fixture-harness.mjs";

const scriptsDir = dirname(fileURLToPath(import.meta.url));
Expand Down
Loading