sessions: align list row hover feedback - #336953
Merged
Sandeep Somavarapu (sandy081) merged 3 commits intoSep 21, 2026
Merged
Sandeep Somavarapu (sandy081) merged 3 commits into
Sandeep Somavarapu (sandy081) merged 3 commits into
Conversation
Sandeep Somavarapu (sandy081)
enabled auto-merge (squash)
September 20, 2026 21:18
Copilot started reviewing on behalf of
Sandeep Somavarapu (sandy081)
September 20, 2026 21:18
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation matches the intended behavior and includes appropriate regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns hover feedback across Agents window session-list rows while preserving spacing and responsive behavior.
Changes:
- Standardizes full-width, square row feedback.
- Preserves shortcut spacing and show-more padding.
- Adds regression coverage for classes, geometry, and padding.
| File | Description |
|---|---|
src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts |
Tests row styling, spacing, and geometry. |
src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts |
Applies section classes and shortcut spacing. |
src/vs/sessions/contrib/sessions/browser/media/sessionsList.css |
Unifies row feedback styling and padding. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Benjamin Christopher Simmonds (benibenj)
previously approved these changes
Sep 20, 2026
Contributor
Screenshot ChangesBase: Changed (63)
|
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_Confetti/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_ArchiveOnboarding/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_ArchiveOnboarding/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_ArchiveOnboarding/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_MarkAsDoneOnboarding/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_MarkAsDoneOnboarding/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_Compact/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_Compact/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactTwistie/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactTwistie/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_UnreadStatusIcons/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_UnreadStatusIcons/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactUnreadStatusIcons/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactUnreadStatusIcons/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactNeedsInput/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactNeedsInput/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactSessionRename/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactSessionRename/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactChatRename/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CompactChatRename/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_LongWorkspaceNarrow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NarrowHoverToolbar/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NarrowHoverToolbar/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_SelectedKeyboardFocus/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_SelectedKeyboardFocus/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_InProgress/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_InProgress/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_PeerChatInProgress/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_PeerChatInProgress/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_WorkspaceSection/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_WorkspaceSection/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Accent/DarkHighContrast
| Before | After |
|---|---|
|
|
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Soft/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Unread/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Narrow/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_AutomationsNewBadge_Running/DarkHighContrast
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_CustomGroup_Phone/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatHierarchyGuides/Light
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Dark
| Before | After |
|---|---|
 |
 |
sessions/sessionsList/SessionsList_NestedChatApprovals_Phone/Light
| Before | After |
|---|---|
 |
 |
chat/agent-lifecycle/chatAgentLifecycle/RetainedFollowUpLatestTurn/LightHighContrast
| Before | After |
|---|---|
 |
 |
2 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Use consistent full-width hover geometry for session, section, shortcut, and show-more rows while preserving each row's content spacing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Accept the component-fixture baselines for the intentional Sessions list hover and spacing changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep the rebased blocks-ci manifest byte-for-byte compatible with the generated fixture list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sandeep Somavarapu (sandy081)
force-pushed
the
agents/bg-hover-feedbacks-are-not-similar-on-folder
branch
from
September 21, 2026 07:49
3680c51 to
213244c
Compare
Giuseppe Cianci (Giuspepe)
approved these changes
Sep 21, 2026
Sandeep Somavarapu (sandy081)
deleted the
agents/bg-hover-feedbacks-are-not-similar-on-folder
branch
September 21, 2026 08:09
Sandeep Somavarapu (sandy081)
added
the
~release-cherry-pick
vs-code-engineering
Bot
added
release-cherry-pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns hover feedback across Sessions list rows so sessions, workspace folders, custom groups, shortcuts, and show-more rows use the same full-width square background.
Preserves the intended content spacing for section labels and show-more separators, and reserves the row-spacing height for shortcut entries. Adds regression coverage for row classes, geometry, and padding.
Validation:
npm run compilenpm run hygiene./scripts/test.sh --run src/vs/sessions/contrib/sessions/test/browser/sessionsList.test.ts(145 passing)