Repository navigation
Conversation
Contributor
CarinaFo
marked this pull request as ready for review
October 18, 2026 09:29
CarinaFo
requested review from
agramfort,
drammock and
larsoner
as code owners
October 18, 2026 09:29
Contributor
| cmap="RdBu_r", | ||
| vmin=-vlim, | ||
| vmax=vlim, | ||
| # Plot cluster result statistic (for now without the actual cluster highlighted) |
Contributor
There was a problem hiding this comment.
@CarinaFo feel free to ping me when are ready for others to try this out (not sure if this comment means there is work you plan to do before putting this up for review0.
Contributor
Author
There was a problem hiding this comment.
I realised that right now we are actually not plotting a cluster but the t-values from the cluster results, which is maybe also interesting for users but we should at least provide the option to highlight clusters. I am still thinking how to do that (probably masking timepoints and channels) and just select the cluster with the lowest p-value? If you have ideas/comments would be great.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds plot_joint method to cluster_result
ToDo: