Repository navigation
add plotting function to new cluster test api #14399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
CarinaFo
wants to merge
15
commits into
mne-tools:main
Choose a base branch
from
CarinaFo:plot_cluster_test_output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
37021d1
added plot joint to cluster_result
CarinaFo 1426be4
change units and scaling for plotting of stats
CarinaFo 463add2
get unit from stat_fun
CarinaFo a421041
use df as input
CarinaFo f24dc49
add minimal test for cluser plotting
CarinaFo 79ae97a
changelog
CarinaFo 0d121e8
wrong PR number in docchange
CarinaFo aa0ce7c
Delete doc/changes/dev/14339.newfeature.rst
CarinaFo acd4acc
wrong username
CarinaFo 178d2a5
add scaling test
CarinaFo 6463b3b
improved test
CarinaFo 77d4b4c
Merge branch 'main' into plot_cluster_test_output
CarinaFo be5e438
plot_joint only supports 2D cluster for now
CarinaFo 850567c
update tutorial
CarinaFo b368507
make sure plot_joing throws an error for 3D input , wrong channel cou…
CarinaFo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Add :meth:`mne.stats.ClusterResult.plot_joint` to visualize the observed cluster test statistic as a joint plot, by `Carina Forster`_. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@CarinaFo feel free to ping me when are ready for others to try this out (not sure if this comment means there is work you plan to do before putting this up for review0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realised that right now we are actually not plotting a cluster but the t-values from the cluster results, which is maybe also interesting for users but we should at least provide the option to highlight clusters. I am still thinking how to do that (probably masking timepoints and channels) and just select the cluster with the lowest p-value? If you have ideas/comments would be great.