Conversation
With PEP-649/PEP-749 semantics this may invoke `__annotate__` with the default format of `Format.VALUE`, which may raise exceptions, but also cause unnecessary work, if the annotations are never inspected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With PEP-649/PEP-749 semantics this may invoke
__annotate__with the default format ofFormat.VALUE, which may raise exceptions, but also cause unnecessary work, if the annotations are never inspected.I've noticed this when removing the
from __future__ import annotationsimport from our code. For some reason with morepath 1.0__annotations__can show up in thedirof parent application classes, which in turn causes a crash inclean_dispatch_methodsif not all the annotations are available at runtime.While it may be a good idea to figure out why
__annotations__can end up indir, it still seems a good idea to always skip accessing it, since even if it doesn't fail, it can still be expensive in Python 3.14+.