Skip to content

Avoid accessing __annotations__ in clean_dispatch_methods #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henri-hulski merged 2 commits into from
Sep 24, 2026
+7 −0
Merged

Avoid accessing __annotations__ in clean_dispatch_methods #71

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00bbdc6
Avoid accessing `__annotations__` in `clean_dispatch_methods`
Daverball Sep 22, 2026
165ebaf
Excludes guard from coverage for now
Daverball Sep 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions reg/context.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,13 @@ def clean_dispatch_methods(cls: type[object]) -> None:
:param cls: a class that has :class:`reg.DispatchMethod` methods on it.
"""
for name in dir(cls):
# NOTE: On Python 3.14+ this can invoke `__annotate__` with format
# `VALUE` which can raise a `NameError`, so it can both cause
# exceptions and also involve unnecessary work, so we explicitly
# avoid touching this attribute
if name == "__annotations__": # pragma: no cover
continue

attr = getattr(cls, name)
if inspect.isfunction(attr) and hasattr(attr, "clean"):
attr.clean() # pyright: ignore[reportFunctionMemberAccess]
Loading