[josefbehr]

The problem

ApiController::updateQuestion() rejects an empty keyValuePairs array with:

This form is archived and can not be modified

The form is not archived. The message has nothing to do with the actual cause, which sends callers looking in the wrong place.

Reproduction

Against Nextcloud 32.0.9 / Forms 5.3.3, on a form that is not archived:

PATCH /ocs/v2.php/apps/forms/api/v3/forms/{formId}/questions/{questionId}
Content-Type: application/json

{"keyValuePairs":{}}

400 | This form is archived and can not be modified

Why this looks like a copy-paste leftover

• The logger->info() call on the line directly above already says Empty keyValuePairs, will not update.
• The method's own @throws annotation documents this case as Empty keyValuePairs, will not update
• The sibling methods updateForm() and updateOption() both report it accurately
• The string matches the archived-form check ~20 lines further up verbatim

Scope

Only the message string changes.

There is a related inconsistency I deliberately left alone: the docblock and both sibling methods use OCSForbiddenException (403) for this case, while updateQuestion() uses OCSBadRequestException (400). Aligning them would change the status code for existing clients, and 400 is arguably the more accurate one for an empty payload anyway. Happy to follow up in either direction if you have a preference.

Context

Found while creating a form through the API.

🤖 Generated with Claude Code

[Chartman123]

/backport to stable5.3

[codecov]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
lib/Controller/ApiController.php	0.00%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)