Repository navigation
fix(nonstop_cli): boot generated apps before flutterfire configure - #43
Merged
Merged
Conversation
Placeholder firebase_options.dart threw before runApp, which left a blank white screen. Skip Firebase-backed modules until configured so the rest of the generated app still starts. Co-authored-by: Cursor <cursoragent@cursor.com>
- nonstop_cli@0.0.8+2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flutterfire configurehas not been run. Bootstrap skips those modules and the rest of the app still starts.firebase_options.dartis not generated.melos version: nonstop_cli 0.0.8+1 → 0.0.8+2.Please merge with a merge commit, not squash
The tag
nonstop_cli-v0.0.8+2is on this branch and will be on the remote after push. It points at thechore(release): publish packagescommit.A merge commit keeps that commit reachable from
main, so the tag stays valid. Squashing would rewrite it and leave the published tag pointing at a commit that is not onmain.Test plan
nonstop create feel_world_remote_3 -y(defaults: Firestore off, other Firebase modules on) →flutter runreaches the dashboard withoutflutterfire configurenonstop create feel_world_no_fb -y --no-auth --no-notifications --no-analytics --no-crashlytics --no-feature-flags --no-developer --no-firestore→ nofirebase_options.dart, no Firebase imports in bootstrapdart test test/src/commands/create_command_test.dartAfter merge
Made with Cursor