Skip to content

fix: make Incidents tab selector case-insensitive#1022

Open
DavidRajnoha wants to merge 1 commit into
openshift:mainfrom
DavidRajnoha:fix/incidents-tab-selector-case-insensitive
Open

fix: make Incidents tab selector case-insensitive#1022
DavidRajnoha wants to merge 1 commit into
openshift:mainfrom
DavidRajnoha:fix/incidents-tab-selector-case-insensitive

Conversation

@DavidRajnoha

@DavidRajnoha DavidRajnoha commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The OpenShift console changed the data-test-id for the Incidents tab from horizontal-link-incidents to horizontal-link-Incidents
  • This caused waitForIncidentsTab to time out in the before all hook, failing all Incidents tests
  • Uses the CSS attribute selector i flag for case-insensitive matching, supporting both casings

Test plan

  • Run incidents E2E suite against a cluster with the updated console
  • Verify the Incidents tab is found during warmUpForPlugin

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • Improved the app’s Incidents tab detection to handle different casing consistently.
    • This should make the Incidents page load checks more reliable in end-to-end flows.

The console changed the data-test-id from "horizontal-link-incidents"
to "horizontal-link-Incidents". Use the CSS `i` flag so the selector
matches both casings.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@openshift-ci openshift-ci Bot requested review from etmurasaki and jgbernalp July 1, 2026 09:18
@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: DavidRajnoha
Once this PR has been reviewed and has the lgtm label, please assign jan--f for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 246cd8fd-ea3f-49cf-9641-de5c2edeef9c

📥 Commits

Reviewing files that changed from the base of the PR and between 4cdeb09 and fd2f1fd.

📒 Files selected for processing (1)
  • web/cypress/views/incidents-page.ts

Walkthrough

The _INCIDENTS_TAB_SELECTOR in the Cypress incidents-page view file was changed from an exact-match CSS attribute selector to a case-insensitive selector, affecting how the Incidents tab is detected during polling in waitForIncidentsTab().

Changes

Incidents tab selector fix

Layer / File(s) Summary
Case-insensitive selector update
web/cypress/views/incidents-page.ts
Changed _INCIDENTS_TAB_SELECTOR from an exact-match to a case-insensitive attribute selector for data-test-id="horizontal-link-incidents".

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: making the Incidents tab selector case-insensitive.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed Only a Cypress page-object selector changed; no Ginkgo test titles were added or modified, so there are no dynamic test names.
Test Structure And Quality ✅ Passed PASS: The PR only updates a Cypress page-object selector; it չի touch any Ginkgo test code, so the Ginkgo quality checklist is not applicable.
Microshift Test Compatibility ✅ Passed Only a Cypress selector changed in web/cypress/views/incidents-page.ts; no new Ginkgo tests or MicroShift-unsupported APIs were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: PR only changes a Cypress page-object selector; no new Ginkgo e2e tests or multi-node assumptions were added.
Topology-Aware Scheduling Compatibility ✅ Passed Only change is a Cypress selector in web/cypress/views/incidents-page.ts; no manifests, controllers, or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed PR only changes a Cypress selector in web/cypress/views/incidents-page.ts; no process-level stdout writes or setup hooks were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed Change is only a Cypress page-object selector update; no new Ginkgo tests or IPv4/external connectivity assumptions were added.
No-Weak-Crypto ✅ Passed Only change is a CSS attribute selector in a Cypress page object; no MD5/SHA/crypto APIs, custom crypto, or secret comparisons added.
Container-Privileges ✅ Passed PR only changes a Cypress selector; repo search found no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivilegeEscalation:true in manifests.
No-Sensitive-Data-In-Logs ✅ Passed PASS: The PR only changes a CSS selector; it adds no new logging or sensitive-data exposure in incidents-page.ts.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

@DavidRajnoha: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant