Skip to content

fix: make Incidents tab selector case-insensitive #1022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DavidRajnoha wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: make Incidents tab selector case-insensitive #1022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions web/cypress/views/incidents-page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,8 @@ const _resetSearchState = () => {
_quietSearch = false;
};

// Selector for the Incidents tab rendered by the Console SDK's HorizontalNav.
// The Console assigns data-test-id="horizontal-link-<href>" to each tab.
const _INCIDENTS_TAB_SELECTOR = '[data-test-id="horizontal-link-incidents"]';
// Case-insensitive selector — the console has shipped both "incidents" and "Incidents".
const _INCIDENTS_TAB_SELECTOR = '[data-test-id="horizontal-link-incidents" i]';

// Selector for bar group containers in the incidents chart (one per incident).
const _BAR_GROUP_SELECTOR = 'g[role="presentation"][data-test*="incidents-chart-bar-"]';
Expand Down