Skip to content

debug-cluster-e2e-aks: add wait step and image override for TLS testing - #83174

Open
kaleemsiddiqu wants to merge 2 commits into
openshift:mainfrom
kaleemsiddiqu:debug-cluster-e2e-aks-azure-tls
Open

debug-cluster-e2e-aks: add wait step and image override for TLS testing#83174
kaleemsiddiqu wants to merge 2 commits into
openshift:mainfrom
kaleemsiddiqu:debug-cluster-e2e-aks-azure-tls

Conversation

@kaleemsiddiqu

@kaleemsiddiqu kaleemsiddiqu commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test for debugging PR openshift/hypershift#8864 (centralized TLS config for cloud-controller-manager). Replace TODO-FILL-IN with the CI registry namespace from the PR's images job before pushing.

Summary by CodeRabbit

  • Updates the openshift/hypershift Azure AKS E2E CI test.
  • Adds a wait step and the hypershift-azure-run-e2e test step for centralized TLS debugging.
  • Overrides the HyperShift operator image with the PR CI build image.

Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test
for debugging PR openshift/hypershift#8864 (centralized TLS config
for cloud-controller-manager). Replace TODO-FILL-IN with the CI
registry namespace from the PR's images job before pushing.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 01ee8e25-b52f-4ef9-b5ca-e30e6b7d8eae

📥 Commits

Reviewing files that changed from the base of the PR and between f61a4e6 and 48b17d2.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

Walkthrough

The Azure AKS E2E test now overrides the HyperShift operator image and runs wait followed by hypershift-azure-run-e2e. Existing post-processing steps remain unchanged.

Changes

Azure AKS E2E execution

Layer / File(s) Summary
Configure Azure AKS E2E steps
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
The e2e-aks test sets OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE and adds the wait and hypershift-azure-run-e2e steps. Existing post-processing steps remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • openshift/release#83108: Both PRs configure HyperShift E2E jobs in openshift-hypershift-main.yaml with image overrides and test steps.

Suggested reviewers: ironcladlou, csrwng


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The added image override sets an internal registry hostname, and the invoked install script logs the full override at line 47 under set -x (lines 3 and 47). Mask or omit the full image reference from logs, and avoid tracing commands that expand OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the added wait step and image override for the Azure AKS TLS debugging test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only an operator image value in CI YAML; it adds no Ginkgo title and the e2e references remain static.
Test Structure And Quality ✅ Passed The pull request changes only one CI YAML image value; it adds or modifies no Ginkgo It blocks, fixtures, waits, cleanup, or assertions.
Microshift Test Compatibility ✅ Passed The pull request changes only one YAML CI configuration value; it adds no Ginkgo tests or test declarations, so MicroShift compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only a CI YAML image reference; it adds no Ginkgo e2e test, so the SNO compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The aggregate PR changes only a CI test YAML block: an operator image override and test references. It adds no deployment, controller, or scheduling constraint.
Ote Binary Stdout Contract ✅ Passed The PR changes one YAML value only; the patch contains no OTE source, main/suite setup, or process-level stdout writes to assess.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only an existing CI YAML test configuration and adds no Ginkgo test declarations or test code with IPv4 or external-network assumptions.
No-Weak-Crypto ✅ Passed The parent-to-HEAD diff changes only the e2e-aks operator image reference; added content contains no weak-crypto algorithms, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR adds one image env var and two test refs; added lines and referenced wait/AKS step manifests contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kaleemsiddiqu
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from csrwng and ironcladlou August 10, 2026 13:13

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`:
- Line 181: Update OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to use the actual CI
registry namespace assigned to this pipeline’s images job instead of the
placeholder ci-op-abc123xyz, while preserving the existing registry path,
pipeline tag, and hypershift-operator image reference.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 2649072d-5005-4158-8e7a-a07537013a88

📥 Commits

Reviewing files that changed from the base of the PR and between 9be95ee and f61a4e6.

📒 Files selected for processing (1)
  • ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

Comment thread ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml Outdated
@kaleemsiddiqu

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Image from release-openshift-origin-installer-launch-aws-modern
job 2086756237780717568 on build10.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@kaleemsiddiqu: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-hypershift-main-e2e-aks openshift/hypershift presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@kaleemsiddiqu

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@kaleemsiddiqu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/hypershift/main/e2e-aks 48b17d2 link unknown /pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant