debug-cluster-e2e-aks: add wait step and image override for TLS testing - #83174
debug-cluster-e2e-aks: add wait step and image override for TLS testing#83174kaleemsiddiqu wants to merge 2 commits into
Conversation
Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test for debugging PR openshift/hypershift#8864 (centralized TLS config for cloud-controller-manager). Replace TODO-FILL-IN with the CI registry namespace from the PR's images job before pushing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Kaleemullah Siddiqui <ksiddiqu@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Azure AKS E2E test now overrides the HyperShift operator image and runs ChangesAzure AKS E2E execution
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kaleemsiddiqu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`:
- Line 181: Update OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to use the actual CI
registry namespace assigned to this pipeline’s images job instead of the
placeholder ci-op-abc123xyz, while preserving the existing registry path,
pipeline tag, and hypershift-operator image reference.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 2649072d-5005-4158-8e7a-a07537013a88
📒 Files selected for processing (1)
ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Image from release-openshift-origin-installer-launch-aws-modern job 2086756237780717568 on build10. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse pull-ci-openshift-hypershift-main-e2e-aks |
|
@kaleemsiddiqu: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@kaleemsiddiqu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Add wait ref and OVERRIDE_HYPERSHIFT_OPERATOR_IMAGE to e2e-aks test for debugging PR openshift/hypershift#8864 (centralized TLS config for cloud-controller-manager). Replace TODO-FILL-IN with the CI registry namespace from the PR's images job before pushing.
Summary by CodeRabbit
openshift/hypershiftAzure AKS E2E CI test.hypershift-azure-run-e2etest step for centralized TLS debugging.