Skip to content

debug-cluster-e2e-aks: add wait step and image override for TLS testing #83174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kaleemsiddiqu wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −0
Open

debug-cluster-e2e-aks: add wait step and image override for TLS testing #83174

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f61a4e6
debug-cluster-e2e-aks: add wait step and image override for TLS testing
kaleemsiddiqu Aug 10, 2026
efc294e
fix: use real image from PR #8864 chat-bot build
kaleemsiddiqu Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ tests:
post:
- ref: hypershift-analyze-e2e-failure
- chain: cucushift-installer-rehearse-azure-aks-deprovision
test:
- ref: wait
- ref: hypershift-azure-run-e2e
Comment on lines +184 to +186

@coderabbitai coderabbitai Bot Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -u

file='ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml'

printf '%s\n' '--- working tree ---'
git status --short

printf '%s\n' '--- relevant YAML ---'
sed -n '165,200p' "$file"

printf '%s\n' '--- diff summary ---'
git diff --stat -- "$file" Makefile ci-operator

printf '%s\n' '--- diff for relevant YAML ---'
git diff -- "$file"

printf '%s\n' '--- repository instructions and generation targets ---'
find .. -name AGENTS.md -o -name CONTRIBUTING.md -o -name Makefile | sort | head -80
rg -n --no-heading '(^|[[:space:]])(update|registry-metadata|ci-operator-config|jobs):|make update|zz_generated_metadata|prow' \
  Makefile ci-operator 2>/dev/null | head -200

printf '%s\n' '--- likely generated files ---'
git ls-files | rg '(^|/)(zz_generated_metadata|prow|jobs|ci-operator-config|registry-metadata)' | head -200

Repository: openshift/release

Length of output: 45095

🏁 Script executed:

#!/bin/bash
set -u

printf '%s\n' '--- Makefile target definitions ---'
sed -n '65,125p' Makefile

printf '%s\n' '--- hypershift generated jobs ---'
find ci-operator/jobs -maxdepth 4 -type f -iname '*hypershift*' -print | sort

printf '%s\n' '--- references to the affected config and steps ---'
rg -n --no-heading 'openshift-hypershift-main|hypershift-azure-run-e2e|as: e2e-aks' \
  ci-operator/jobs ci-operator/config/openshift/hypershift 2>/dev/null | head -120

printf '%s\n' '--- metadata in the affected config ---'
rg -n --no-heading -A12 -B2 'zz_generated_metadata:' \
  ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml

Repository: openshift/release

Length of output: 32887

🏁 Script executed:

#!/bin/bash
set -u

job='ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml'
config='ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml'

printf '%s\n' '--- generated e2e-aks job ---'
sed -n '270,372p' "$job"

printf '%s\n' '--- generated job references to affected steps ---'
rg -n --no-heading -C3 'hypershift-azure-run-e2e|ref: wait|e2e-aks' "$job" | head -120

printf '%s\n' '--- config metadata and all generated metadata references ---'
rg -n --no-heading -C2 'zz_generated_metadata:|branch: main|org: openshift|repo: hypershift' "$config" | head -40

printf '%s\n' '--- read-only structural check ---'
python3 - <<'PY'
from pathlib import Path

config = Path("ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml").read_text()
job = Path("ci-operator/jobs/openshift/hypershift/openshift-hypershift-main-presubmits.yaml").read_text()

print("config_has_wait:", "- ref: wait" in config)
print("config_has_hypershift_azure_run_e2e:", "- ref: hypershift-azure-run-e2e" in config)
print("job_has_hypershift_azure_run_e2e:", "hypershift-azure-run-e2e" in job)
print("job_has_ref_wait:", "ref: wait" in job)
print("job_has_e2e_aks_job:", "pull-ci-openshift-hypershift-main-e2e-aks" in job)
PY

Repository: openshift/release

Length of output: 7030

Run make update and review the generated diffs.

make update already runs jobs, ci-operator-config, and registry-metadata; no separate command sequence is required. The generated Prow job references --target=e2e-aks and does not inline the test steps.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ci-operator/config/openshift/hypershift/openshift-hypershift-main.yaml`
around lines 184 - 186, Run make update to regenerate the affected CI
configuration, then review the generated diffs. Use the generated Prow job
configuration, preserving its --target=e2e-aks reference and avoiding manually
inlining test steps or running separate update commands.

Sources: Coding guidelines, Learnings

workflow: hypershift-azure-aks-e2e
- always_run: false
as: e2e-aks-4-22
Expand Down