Conversation
somiaj
approved these changes
Sep 25, 2026
drgrice1
force-pushed
the
bugfix/gateway-passback-zero-total
branch
from
September 25, 2026 20:21
2f5fe2d to
6b08a03
Compare
Previously a set version only replaced the initial [0, 0] best set data if its score was greater than zero. So if a user scored zero on all versions of a test, or had not started the test, the total returned was also zero. For LTI 1.3 grade passback that resulted in a scoreMaximum of zero being sent, which Canvas rejects with "cannot be zero if line item's maximum is not zero". Now the first version is used if no version has a positive score, and if there are no versions the total is computed from the problems assigned to the user for the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This is a more informative message, and Moodle is also now sending a JSON response (perhaps it always was, and I was confusing this request with one of the other LTI requests).
drgrice1
force-pushed
the
bugfix/gateway-passback-zero-total
branch
from
September 25, 2026 20:23
6b08a03 to
ac6efcc
Compare
Member
Author
|
I tested with Moodle now, and even Moodle sends a JSON response with a more informative message using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously a set version only replaced the initial [0, 0] best set data if its score was greater than zero. So if a user scored zero on all versions of a test, or had not started the test, the total returned was also zero. For LTI 1.3 grade passback that resulted in a scoreMaximum of zero being sent, which Canvas rejects with "cannot be zero if line item's maximum is not zero".
Now the first version is used if no version has a positive score, and if there are no versions the total is computed from the problems assigned to the user for the test.
Aside: I have been seeing the message "Failed to send grade: Unprocessable Entity" quite frequently because of this. Changing line 366 of
lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pmto$self->warning(join("\n", 'Failed to send grade:', $response->body));gives the more meaningful message above. Note this message issue I am looking for a better solution for. The real problem is Moodle doing things quite badly. It seems that all other LMS's give a JSON response. Canvas literally gives{"errors":{"type":"unprocessable_entity","message":"cannot be zero if line item's maximum is not zero"}}in this case. I am rather certain that D2L also gives this sort of JSON response from what I have seen when @dlglin and @Alex-Jordan test things. Moodle on the other hand gives an HTML response that has a body that is quite large and useless, and the$response->messageis a brief and more meaningful message. Perhaps this should just be switched to$response->bodyand make Moodle users decipher the big HTML content (the message is hidden in it I believe)? Although, maybe Moodle has fixed this. I don't think I have tested this for a while with Moodle.