Skip to content

Fix the total returned by grade_gateway when the best score is zero. #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drgrice1 wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix the total returned by grade_gateway when the best score is zero. #3220

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d6d25e
Fix the total returned by grade_gateway when the best score is zero.
drgrice1 Sep 25, 2026
ac6efcc
Also switch to using `$response->body` for the failure message.
drgrice1 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/WeBWorK/Authen/LTIAdvantage/SubmitGrade.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -363,7 +363,7 @@ async sub submit_grade ($self, $LMSuserID, $lineitem, $scoreGiven, $scoreMaximum
return 1;
}

$self->warning(join("\n", 'Failed to send grade:', $response->message));
$self->warning(join("\n", 'Failed to send grade:', $response->body));
return 0;
}

Expand Down
17 changes: 14 additions & 3 deletions lib/WeBWorK/Utils/Sets.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,12 +107,21 @@ sub grade_set ($db, $set, $studentName, $setIsVersioned = 0, $wantProblemDetails
}

sub grade_gateway ($db, $setName, $studentName) {
my $bestSetData = [ 0, 0, [] ];
my $bestSetData;

my @setVersions = $db->getSetVersionsWhere({ user_id => $studentName, set_id => $setName });
for (@setVersions) {
my @setData = grade_set($db, $_, $studentName, 1);
$bestSetData = \@setData if $setData[0] > $bestSetData->[0];
$bestSetData = \@setData if !$bestSetData || $setData[0] > $bestSetData->[0];
}

# If the student has not started the test, then the total is still needed for a score of zero out of that total.
unless ($bestSetData) {
my $total = 0;
for ($db->getAllMergedUserProblems($studentName, $setName)) {
$total += defined $_->value && $_->value ne '' ? $_->value : 1;
}
$bestSetData = [ 0, $total, [] ];
}

return wantarray ? (@$bestSetData, \@setVersions) : ($bestSetData->[1] ? $bestSetData->[0] / $bestSetData->[1] : 0);
Expand Down Expand Up @@ -327,7 +336,9 @@ In list context this returns a list of the total number of correct problems for
the highest scoring version of this test, the total number of problems in that
version, a reference to an array of merged user problem records from that
version, and a reference to an array of merged user set versions for this user
and set.
and set. If the user has no versions of the test, then the total is computed
from the problems assigned to the user for the test, and the array of problem
records is empty.

In scalar context this returns the percentage correct for the highest scoring
version of this test.
Expand Down