Repository navigation
Conversation
- Dropped Python 3.10 from CI and the PyPI build since it reached end of life. - Raised python_requires to 3.11 and updated the classifiers and README. - Removed the Python 2 coding declarations from runtests.py and the docs configuration. Closes #88
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Linked Issues check |  |
Issue #88 has coding requirements in two groups.Group 1: Remove Python 3.10 from supported versions, CI matrix, and package metadata. Evidence at head: setup.py sets python_requires=">=3.11". Its cl… |
Confirm that no code under netengine/ or tests/ exists only to support Python 3.10 or older. Specifically, check for sys.version_info or platform version checks, version-gated imports, and compatibility shims. Report the result, or the remo… |
-
Check name Status Explanation Title check The title uses the allowed [deps] prefix and clearly describes the removal of Python 3.10 support, which matches the changeset and linked issue. Description check The description includes the checklist, issue reference, and a clear summary of the changes. The screenshot section is not included, but no screenshot appears necessary for these configuration and met… Out of Scope Changes check All changed files relate to the scope of #88. The changes are: ci.yml (3.10 removed from matrix), pypi.yml (build uses Python 3.11), README.rst (supported versions), setup.py (python_requires and clas…Ui Changes, Regression Test, Docs PASS. The PR changes only CI, package metadata, documentation, and encoding declarations. It introduces no end-user UI change and no application-code feature or bug fix, so screenshots and regression … Full details: Description check
-
Explanation
The description includes the checklist, issue reference, and a clear summary of the changes. The screenshot section is not included, but no screenshot appears necessary for these configuration and metadata changes.
Full details: Out of Scope Changes check
-
Explanation
All changed files relate to the scope of
#88. The changes are: ci.yml (3.10 removed from matrix), pypi.yml (build uses Python 3.11), README.rst (supported versions), setup.py (python_requires and classifiers), and runtests.py and docs/source/conf.py (Python 2 UTF-8 coding declarations removed). The Python 2 declarations exist only for Python 2, which is older than 3.10. Removing them fits the issue's request to remove code that exists only for older Python versions. The docs conf.py and runtests.py edits do not change behavior, according to the summary. No unrelated functional changes appear in the summary. No new tests are added, and the PR description marks new tests as N/A. This is not an out-of-scope change.
Full details: Ui Changes, Regression Test, Docs
-
Explanation
PASS. The PR changes only CI, package metadata, documentation, and encoding declarations. It introduces no end-user UI change and no application-code feature or bug fix, so screenshots and regression tests are not required. The supported-version documentation in README.rst was updated from Python 3.10–3.13 to Python 3.11–3.13.
-
Full details: Linked Issues check
-
Explanation
Issue
#88has coding requirements in two groups.Group 1: Remove Python 3.10 from supported versions, CI matrix, and package metadata. Evidence at head: setup.py sets python_requires=">=3.11". Its classifiers list 3.11, 3.12, and 3.13 only. The raw summary reports the CI matrix (ci.yml), the PyPI workflow (pypi.yml), and README.rst changed to drop 3.10. This group appears met.
Group 2: Remove or refactor code that exists only for Python 3.10 or older (version checks, compatibility shims, backport dependencies). Backport dependencies: requirements.txt lists only netaddr~=1.3.0 and pysnmp~=7.1.30. requirements-test.txt has no version-gated backport packages. No such dependency is present. Version checks and compatibility shims: the raw summary lists no changes under netengine/ or tests/. The PR does not report any removal of such code. The search for sys.version_info checks, version-gated imports, or shims in netengine/ and tests/ was not completed. Absence of such code is not established.
Resolution
Confirm that no code under netengine/ or tests/ exists only to support Python 3.10 or older. Specifically, check for sys.version_info or platform version checks, version-gated imports, and compatibility shims. Report the result, or the removed code if any was found, so the Python-version-specific code requirement from
#88can be decided.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Checklist
Reference to Existing Issue
Closes #88.
Description of Changes
python_requiresto 3.11 and updated the classifiers and the README.runtests.pyand the docs configuration.