Repository navigation
postgres-fdw.sgmlの18.6対応です - #3738
Merged
Merged
Conversation
KenichiroTanaka
requested changes
Sep 29, 2026
KenichiroTanaka
left a comment
KenichiroTanaka
left a comment
Contributor
There was a problem hiding this comment.
とても細かいですが1か所だけ気づくところがありましたので見ていただいてもいいでしょうか。
| ユーザマッピング設定は外部サーバ設定より優先されます。 | ||
| SCRAMパススルー認証では、<filename>postgres_fdw</filename> SCRAMでハッシュされたシークレット代わりplain-テキストユーザパスワードを使用してリモートサーバに接続します。 | ||
| これにより、plain-テキストユーザパスワードがPostgreSQLシステムカタログに保存されるのを回避できます。 | ||
| SCRAMパススルー認証では、<filename>postgres_fdw</filename>はプレーンテキストユーザパスワードの代わりにSCRAMハッシュ化されたシークレットを使用してリモートサーバに接続します。 |
Contributor
There was a problem hiding this comment.
細かいですが、次の1138行目とで
「プレーンテキストユーザパスワード」
「プレーンテキストのユーザパスワード」
の違いが気になりましたので揃えていただいてもいいでしょうか
「の」がある方が読みやすいのかなと思います。
KenichiroTanaka
approved these changes
Oct 2, 2026
KenichiroTanaka
left a comment
KenichiroTanaka
left a comment
Contributor
There was a problem hiding this comment.
対応ありがとうございます。マージします。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.