Repository navigation
Skip the Psr4 sniff instead of aborting when composer.json is missing - #89
Merged
Merged
Conversation
The sniff already marked itself as failed before calling the factory and returned early on that state, but the factory's InvalidArgumentException was never caught, so running phpcs from a directory without composer.json killed the whole run with a fatal error. Only the missing/unreadable case is caught. A composer.json with invalid JSON still throws, so a broken config stays visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #86
Running phpcs from a directory without a
composer.jsonno longer aborts the whole run.Psr4Sniffcatches the factory'sInvalidArgumentException(missing or unreadable file) and disables only itself, which is what the existingINITIALIZATION_FAILUREstate was meant to do. Invalid JSON in an existingcomposer.jsonstill throws, so a broken config stays visible.