Repository navigation
chore: standardize automatic skill sources and PHPDoc bootstrap - #13
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure skill sources and synchronization skills.json, CONTRIBUTING.md, .changelog/consistent-skill-sources.md |
The configuration pins the schema, trusts fast-forward/*, adds a local skill source, and updates the GitHub changelog source to ^0.4.0 without a skill filter. Contributor instructions describe automatic synchronization and explicit refresh. The changelog records these updates. |
PHPDoc tooling setup
| Layer / File(s) | Summary |
|---|---|
Configure PHPDoc checks and repository settings composer.json, .php-cs-fixer.dist.php, .gitignore, .gitattributes |
The PHP-CS-Fixer configuration loads the project autoloader, excludes tooling directories, and enables PHPDoc rules. Composer approves phpro/grumphp-shim. Repository settings ignore /.dev-tools/ and exclude the fixer configuration from exports. |
Example autoloader paths
| Layer / File(s) | Summary |
|---|---|
Update example autoloader paths examples/01-system-clock.php, examples/02-system-clock-with-timezone.php, examples/03-frozen-clock.php, examples/04-frozen-clock-inputs.php, examples/05-frozen-clock-container.php, examples/06-psr20-clock-interface.php |
The six examples now build the Composer autoloader path from __DIR__. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- [architecture] Make DevTools the profile-based bootstrap and upgrade orchestrator for domain packages dev-tools#384 — The PR updates clock’s skill sources and trust policy, a consumer-side implementation related to the issue’s bootstrap and upgrade orchestration.
- [architecture] Plan domain-owned tooling extraction and DevTools orchestration dev-tools#240 — The PR applies consumer-side skill and PHPDoc configuration in clock, which the issue identifies as a migration target.
- [architecture] Reassess isolated tooling distribution after CPX and domain extraction dev-tools#197 — The PHPDoc configuration loads the project autoloader, but the PR does not implement isolated distribution.
- Extract Code Standards: formatting, PHPDoc and explicit refactoring code-standards#1 — The PR changes a PHPDoc quality profile but does not implement canonical skill ownership.
- [architecture] Map domain-owned skills and replace redundant agent distribution dev-tools#195 — The PR updates trusted skill sources, local skill discovery, and automatic synchronization.
- Extract PHPDoc policy and opt-in semantic refactoring code-standards#4 — The PR changes the PHPDoc profile and consumer autoloading, but does not extract the policy.
- Compare resolved ECS and CoiSA policies with golden fixtures code-standards#5 — The PR enables PHPDoc rules, but does not perform the full header and policy comparison.
Merge Risk: 
c98d2
-
No merge-blocking issue was identified; the PR is mergeable with normal checks.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the main changes: standardizing automatic skill sources and the PHPDoc bootstrap. Description check The description directly covers the skill configuration, PHPDoc bootstrap, Composer metadata, example paths, validation, and related changes. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 7 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the skill sources bright
Local and GitHub paths align just right
PHPDocs get a tidy rule
Examples find the loader tool
Six small paths hop into place
Then I nibble, pleased with the trace
Comment @coderabbitai help to get the list of available commands.
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
Standardize the contributor skill configuration across Fast Forward libraries: use
fast-forward/*withtrusted-replace, keepauto-sync: true, and register the localresources/skillsdirectory without a package override. The GitHub Changelog source now uses^0.4.0and discovers its Composer-declared payload without a redundant skill allowlist. Pin the schema to the verified installer release and add a patch fragment.The project PHPDoc profile loads the consumer autoloader, avoiding DevTools 1.x's nonexistent nested autoloader, and preserves existing file/license headers while checking PHPDoc structure. Keep generated development output ignored and the profile outside Composer archives. Explicitly allow the GrumPHP shim already required by DevTools so Composer can activate the reviewed development commands.
Normalize example autoloader paths and Composer metadata ordering to satisfy the existing Rector and style rules.
Validation
composer validate --strictand the completecomposer dev-toolspipeline passed, including Rector, PHPDoc, code style, PHPUnit/coverage, API/guide documentation and metrics.git commit; no hook bypass or relaxed check was used for this correction.origin/mainand whitespace checks passed.84e154046e07cafa6ac09a9e12434b1ff5dcb5e0. Test counts remain 43 tests / 84 assertions.No merge, release or runtime dependency upgrade is included.