Repository navigation
chore: standardize automatic skill sources and PHPDoc bootstrap - #16
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Skill source settings skills.json, composer.json |
skills.json now uses the 1.15.0 schema, trusts fast-forward/* with trusted-replace, adds resources/skills as a directory source, and updates the Changelog source ref to ^0.4.0. The llm/skills Composer plugin entry moves; its value is unchanged. |
PHPDoc formatting setup .php-cs-fixer.dist.php, src/Calendar/Quarter.php, src/Calendar/Semester.php, src/Sort/ComparisonResult.php, src/StateMachine/InvalidTransitionException.php, src/Trait/HasNameLookup.php, .gitattributes, .changelog/consistent-skill-sources.md |
The new PHP-CS-Fixer profile loads the project autoloader, disables risky fixes, configures the finder, and enables PHPDoc rules. The listed files lose selected @return self annotations; their method signatures and behavior remain unchanged. .gitattributes excludes the profile from exported archives. The changelog records the skill-source and PHPDoc-check changes. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Other
Possibly related issues
- [architecture] Make DevTools the profile-based bootstrap and upgrade orchestrator for domain packages dev-tools#384 — The PR configures
fast-forward/*trust and a local skill source, which relates to the issue’s skill provenance and consumer synchronization objectives. - [architecture] Plan domain-owned tooling extraction and DevTools orchestration dev-tools#240 — The trusted donors and local skill source relate to the issue’s skill ownership model.
- [RFC / Architecture] Extract Wiki and docs into a standalone PHP package, CLI, skill and automation dev-tools#367 — The PHP-CS-Fixer profile loads the project autoloader, which relates to the issue’s proposed documentation-generation boundary.
- Verify fork PR automation and fresh Composer distribution code-standards#2 — The PR excludes the PHP-CS-Fixer profile from archives and configures it to load the project autoloader, matching parts of the issue’s archive and autoload validation scope.
- Extract Code Standards: formatting, PHPDoc and explicit refactoring code-standards#1 — The PR adds PHPDoc formatting and annotation rules, which relate to the issue’s PHPDoc structure checks.
- [architecture] Map domain-owned skills and replace redundant agent distribution dev-tools#195 — The PR configures trusted external and local skill sources, which relates to the issue’s skill-source provenance objectives.
Merge Risk: 
d9b10
-
No issue requiring a fix before merge was identified.
Pre-merge checks: 
-
Check name Status Explanation Description check The description directly covers the skill-source configuration, PHPDoc bootstrap, documentation cleanup, validation, and archive changes in the pull request. Title check The title clearly summarizes the two main changes: standardizing automatic skill sources and updating the PHPDoc bootstrap. Docstring Coverage No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files.
-
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checked the source list twice,
Then watched the local skills arrive.
PHPDoc rules lined up in rows,
While archive files left out the config.
“No return note,” the rabbit said,
And hopped through changelog lines instead.
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
|
🚀 Preview is available for this pull request. |
Standardize the contributor skill configuration across Fast Forward libraries: use
fast-forward/*withtrusted-replace, keepauto-sync: true, and register the localresources/skillsdirectory without a package override. The GitHub Changelog source now uses^0.4.0and discovers its Composer-declared payload without a redundant skill allowlist. Pin the schema to the verified installer release and add a patch fragment.The project PHPDoc profile loads the consumer autoloader, avoiding DevTools 1.x's nonexistent nested autoloader, and preserves existing file/license headers while checking PHPDoc structure. Keep generated development output ignored and the profile outside Composer archives.
Remove redundant enum factory and name-lookup return tags already expressed by native return types.
Validation
composer validate --strictand completecomposer dev-toolspassed, including Rector, PHPDoc, code style, PHPUnit/coverage, API/guide documentation and metrics.git commit, without bypasses or relaxed checks.origin/mainand whitespace checks passed.84e154046e07cafa6ac09a9e12434b1ff5dcb5e0; 88 tests / 237 assertions.No merge, release or runtime dependency upgrade is included.