Repository navigation
chore: standardize automatic skill sources and PHPDoc bootstrap - #11
Conversation
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Skill source settings skills.json, .changelog/consistent-skill-sources.md |
The configuration uses the versioned 1.15.0 schema, trusts fast-forward/*, enables trusted-replace, and adds resources/skills as a local source. The changelog source ref changes to ^0.4.0, and its explicit skill list is removed. The changelog records these and the PHPDoc-check changes. |
PHPDoc-check setup .php-cs-fixer.dist.php, composer.json, .gitignore, .gitattributes, examples/bootstrap.php, src/Worker/Worker.php, tests/Manager/ForkManagerTest.php, tests/Worker/* |
A PHP-CS-Fixer configuration loads the project autoloader, excludes tooling directories, disables risky fixers, and configures PHPDoc rules. Composer permits phpro/grumphp-shim; .dev-tools/ is ignored, and the fixer configuration is excluded from exported archives. The example autoloader expression resolves to the same parent-directory vendor path. Import spacing changes, and a test docblock loses its @return Worker annotation. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Other
Possibly related issues
- [architecture] Map domain-owned skills and replace redundant agent distribution dev-tools#195: The skill-source settings cover configuration for trusted sources and local skills, which are part of the issue’s skill distribution contract. The issue also covers design-validation topics not described in this pull request.
Possibly related PRs
- php-fast-forward/fork#8: That PR adds the bundled skill under
resources/skills; this pull request registers that directory as a local skill source.
Merge Risk: 
2e7fe
-
The reviewed changes are mergeable with no identified current-head risk.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the main changes: standardizing automatic skill sources and updating the PHPDoc bootstrap. Description check The description directly explains the skill configuration, PHPDoc bootstrap, Composer settings, validation results, and related cleanup changes. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 6 files. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the skills in place
And tidies PHP docs with care
The trusted sources join the list
A local path is now declared
Then hops away through export’s gate
Comment @coderabbitai help to get the list of available commands.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
Standardize the contributor skill configuration across Fast Forward libraries: use
fast-forward/*withtrusted-replace, keepauto-sync: true, and register the localresources/skillsdirectory without a package override. The GitHub Changelog source now uses^0.4.0and discovers its Composer-declared payload without a redundant skill allowlist. Pin the schema to the verified installer release and add a patch fragment.The project PHPDoc profile loads the consumer autoloader, avoiding DevTools 1.x's nonexistent nested autoloader, and preserves existing file/license headers while checking PHPDoc structure. Keep generated development output ignored and the profile outside Composer archives. Explicitly allow the GrumPHP shim already required by DevTools so Composer can activate the reviewed development commands.
Normalize the example autoloader path, redundant return PHPDoc and existing worker test/source spacing.
Validation
composer validate --strictand the completecomposer dev-toolspipeline passed: Rector, PHPDoc, code style, PHPUnit/coverage, API/guide documentation and metrics.git commit, without a hook bypass or relaxed checks.origin/mainand whitespace checks passed.84e154046e07cafa6ac09a9e12434b1ff5dcb5e0; 81 tests / 194 assertions.No merge, release or runtime dependency upgrade is included.