Repository navigation
chore: standardize automatic skill sources and PHPDoc bootstrap - #10
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Configure skill sources skills.json, .changelog/consistent-skill-sources.md |
The skill configuration uses schema version 1.15.0, trusts fast-forward/*, enables trusted-replace, adds the resources/skills source, and updates the GitHub changelog source to ^0.4.0. The changelog records these updates and PHPDoc autoloader loading. |
PHP tooling and code adjustments
| Layer / File(s) | Summary |
|---|---|
Configure PHP-CS-Fixer .php-cs-fixer.dist.php, composer.json, .gitignore, .gitattributes |
The fixer configuration loads the project autoloader, sets project discovery and PHPDoc rules, and disables risky rules. Composer permits the phpro/grumphp-shim plugin. The repository ignores .dev-tools/ and excludes the fixer configuration from exports. |
Update example autoloader paths examples/* |
The examples build the vendor autoloader path from __DIR__ and a parent-directory segment. |
Make test closures static tests/ClosureFactoryIteratorAggregateTest.php, tests/ClosureIteratorIteratorTest.php, tests/ConsecutiveGroupIteratorTest.php, tests/GeneratorRewindableIteratorTest.php, tests/GroupByIteratorIteratorTest.php, tests/ConsumerSkillTest.php |
Iterator test closures and arrow functions are now static. The consumer skill test calls dirname without a leading namespace separator. |
Priority:
Estimated code review effort: 2 (Simple) | ~12 minutes
Change: Other
Possibly related PRs
- php-fast-forward/iterators#8: Adds the bundled skill payload and registers its Composer skill source, which this PR configures for discovery and synchronization.
Merge Risk: 
95897
-
No actionable merge-blocking risk is established by the reviewed changes.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the main changes: standardizing automatic skill sources and adding the PHPDoc bootstrap. Description check The description directly explains the skill configuration, PHPDoc bootstrap, Composer changes, validation, and related cleanup in the changeset. Docstring Coverage Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 24 files. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request.
Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit checks the skills in place,
Then sets a fixer’s rules with care.
Through example paths it hops along,
Static closures join the song.
The changelog marks what changed today.
Comment @coderabbitai help to get the list of available commands.
Changelog✅ Contribution check passed. Head: Base: Contribution: 1 new valid fragment(s). Policy: ordinary.
|
Standardize the contributor skill configuration across Fast Forward libraries: use
fast-forward/*withtrusted-replace, keepauto-sync: true, and register the localresources/skillsdirectory without a package override. The GitHub Changelog source now uses^0.4.0and discovers its Composer-declared payload without a redundant skill allowlist. Pin the schema to the verified installer release and add a patch fragment.The project PHPDoc profile loads the consumer autoloader, avoiding DevTools 1.x's nonexistent nested autoloader, and preserves existing file/license headers while checking PHPDoc structure. Keep generated development output ignored and the profile outside Composer archives. Explicitly allow the GrumPHP shim already required by DevTools so Composer can activate the reviewed development commands.
Normalize example autoloader paths and the existing iterator regression tests' formatting under the unchanged checks.
Validation
composer validate --strictand completecomposer dev-toolspassed, including Rector, PHPDoc, code style, PHPUnit/coverage, API/guide documentation and metrics.git commit, without bypasses or relaxed checks.origin/mainand whitespace checks passed.84e154046e07cafa6ac09a9e12434b1ff5dcb5e0; 101 tests / 128 assertions.No merge, release or runtime dependency upgrade is included.