ext/bcmath: bounds-check $precision in bcround() and Number::round()#22182
Open
edorian wants to merge 3 commits into
Open
ext/bcmath: bounds-check $precision in bcround() and Number::round()#22182edorian wants to merge 3 commits into
$precision in bcround() and Number::round()#22182edorian wants to merge 3 commits into
Conversation
Fix ASAN issue withh entry points passed $precision to bc_round() unchecked, allowing PHP_INT_MAX / PHP_INT_MIN to trigger oversized allocations and signed overflow in libbcmath/src/round.c.
- remove the zend_always_inline - use INT_MIN instead of -INT_MAX - use % matching in the tests so they work on 32bit
devnexen
reviewed
May 29, 2026
|
|
||
| static zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num) | ||
| { | ||
| if (UNEXPECTED(precision < INT_MIN || precision > INT_MAX)) { |
Member
There was a problem hiding this comment.
nit: ZEND_LONG_EXCEEDS_INT macro might works fine for your case.
Member
Author
There was a problem hiding this comment.
Thank you, wasn't aware of that macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the ASAN issue with entry points passing
$precisiontobc_round()unchecked, allowing PHP_INT_MAX / PHP_INT_MIN to trigger oversized allocations and signed overflow in libbcmath/src/round.c.Transparency Note: The ASAN issue was found during LLM-based scanning. Code partially generated by tooling, reviewed and tested by me.