Skip to content

ext/bcmath: bounds-check $precision in bcround() and Number::round() #22182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edorian wants to merge 3 commits into
base: master
Choose a base branch
from
+49 −0
Open

ext/bcmath: bounds-check $precision in bcround() and Number::round() #22182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
89e383d
ext/bcmath: bounds-check $precision in bcround() and Number::round()
edorian May 29, 2026
5b86f5d
Inital review feedback
edorian May 29, 2026
e508ea6
Use ZEND_LONG_EXCEEDS_INT over manual bound checking
edorian May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions ext/bcmath/bcmath.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,15 @@ static zend_always_inline zend_result bcmath_check_scale(zend_long scale, uint32
return SUCCESS;
}

static zend_result bcmath_check_precision(zend_long precision, uint32_t arg_num)
{
if (ZEND_LONG_EXCEEDS_INT(precision)) {
zend_argument_value_error(arg_num, "must be between %d and %d", INT_MIN, INT_MAX);
return FAILURE;
}
return SUCCESS;
}

static void php_long2num(bc_num *num, zend_long lval)
{
*num = bc_long2num(lval);
Expand Down Expand Up @@ -795,6 +804,10 @@ PHP_FUNCTION(bcround)
Z_PARAM_ENUM(rounding_mode, rounding_mode_ce)
ZEND_PARSE_PARAMETERS_END();

if (bcmath_check_precision(precision, 2) == FAILURE) {
RETURN_THROWS();
}

switch (rounding_mode) {
case ZEND_ENUM_RoundingMode_HalfAwayFromZero:
case ZEND_ENUM_RoundingMode_HalfTowardsZero:
Expand Down Expand Up @@ -1794,6 +1807,10 @@ PHP_METHOD(BcMath_Number, round)
Z_PARAM_ENUM(rounding_mode, rounding_mode_ce);
ZEND_PARSE_PARAMETERS_END();

if (bcmath_check_precision(precision, 1) == FAILURE) {
RETURN_THROWS();
}

switch (rounding_mode) {
case ZEND_ENUM_RoundingMode_HalfAwayFromZero:
case ZEND_ENUM_RoundingMode_HalfTowardsZero:
Expand Down
32 changes: 32 additions & 0 deletions ext/bcmath/tests/bcround_precision_bounds.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
--TEST--
bcround() and BcMath\Number::round() reject out-of-range $precision
--EXTENSIONS--
bcmath
--FILE--
<?php
try {
bcround('1', PHP_INT_MAX);
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}
try {
bcround('12345', -PHP_INT_MAX, RoundingMode::AwayFromZero);
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}
try {
bcround('12345', PHP_INT_MIN, RoundingMode::AwayFromZero);
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}
try {
(new BcMath\Number('1'))->round(PHP_INT_MAX);
} catch (\ValueError $e) {
echo $e->getMessage() . \PHP_EOL;
}
?>
--EXPECTF--
bcround(): Argument #2 ($precision) must be between %i and %i
bcround(): Argument #2 ($precision) must be between %i and %i
bcround(): Argument #2 ($precision) must be between %i and %i
BcMath\Number::round(): Argument #1 ($precision) must be between %i and %i
Loading