ext/hash: report argument #2 ($filename) for null bytes in hash_file() - #23534
Merged
Conversation
php_hash_do_hash() hardcodes argument index 1 in the isfilename branch, so hash_file() blames $algo for a null byte carried by $filename. hash_file() is the only caller passing isfilename = 1, and its filename is argument #2; php_hash_do_hash_hmac() already uses 2 for the same check.
NickSdot
reviewed
Sep 1, 2026
Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
devnexen
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php_hash_do_hash()hardcodes argument index 1 in itsisfilenamebranch, sohash_file()blames$algofor a null byte that was carried by$filename.hash_file()is the only caller passingisfilename = 1, and its filename is argument 2.Before:
After:
php_hash_do_hash_hmac()already reports 2 for the same check, sohash_hmac_file()was right andhash_file()was the odd one out. Only the error message changes; a test case is added.