Skip to content

ext/hash: report argument #2 ($filename) for null bytes in hash_file() #23534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devnexen merged 2 commits into from
Sep 2, 2026
+11 −1
Merged

ext/hash: report argument #2 ($filename) for null bytes in hash_file() #23534

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a3cb82b
ext/hash: report argument #2 ($filename) for null bytes in hash_file()
lacatoire Aug 18, 2026
ee4cbb1
Update ext/hash/tests/hash_file_error.phpt
lacatoire Sep 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/hash/hash.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ static void php_hash_do_hash(
}
if (isfilename) {
if (zend_char_has_nul_byte(data, data_len)) {
zend_argument_value_error(1, "must not contain any null bytes");
zend_argument_value_error(2, "must not contain any null bytes");
RETURN_THROWS();
}
stream = php_stream_open_wrapper_ex(data, "rb", REPORT_ERRORS, NULL, FG(default_context));
Expand Down
10 changes: 10 additions & 0 deletions ext/hash/tests/hash_file_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,13 @@ try {
echo $exception::class, ': ', $exception->getMessage(), "\n";
}

echo "\n-- Testing hash_file() function with a null byte in the filename --\n";
try {
hash_file('md5', $filename . chr(0) . $filename);
} catch (Throwable $e) {
echo $e::class, ': ', $e->getMessage(), "\n";
}

echo "\n-- Testing hash_file() function with a non-existent file --\n";
var_dump(hash_file('md5', 'nonexistent.txt'));

Expand All @@ -36,6 +43,9 @@ unlink( $filename );
-- Testing hash_file() function with an unknown algorithm --
ValueError: hash_file(): Argument #1 ($algo) must be a valid hashing algorithm

-- Testing hash_file() function with a null byte in the filename --
ValueError: hash_file(): Argument #2 ($filename) must not contain any null bytes

-- Testing hash_file() function with a non-existent file --

Warning: hash_file(): Failed to open stream: No such file or directory in %s on line %d
Expand Down
Loading