Skip to content

Add more description to AUTO_RANDOM - #23498

Merged
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
qiancai:auto_random-21863
Aug 12, 2026
Merged

Add more description to AUTO_RANDOM#23498
ti-chi-bot[bot] merged 3 commits into
pingcap:masterfrom
qiancai:auto_random-21863

Conversation

@qiancai

@qiancai qiancai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

What is changed, added or deleted? (Required)

close #23404

Add 2 more descriptions:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified signed and unsigned column behavior in AUTO_RANDOM bit layouts.
    • Documented that implicitly generated values are always positive with a zero signed bit.
    • Added the minimum 27-bit requirement for auto-increment bits.

@qiancai qiancai added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Aug 12, 2026
@ti-chi-bot ti-chi-bot Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2026
Synced from: pingcap/docs-cn#21863
Target PR: pingcap#23498

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Auto-sync completed successfully

Source PR: pingcap/docs-cn#21863
Target PR: #23498

English documentation has been updated based on Chinese documentation changes.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 78bcdcec-bf72-403c-9780-78d34df26582

📥 Commits

Reviewing files that changed from the base of the PR and between 1e0eb57 and 6ac0372.

📒 Files selected for processing (1)
  • auto-random.md

📝 Walkthrough

Walkthrough

The AUTO_RANDOM documentation now distinguishes signed and unsigned columns, states that implicit values are always positive, and defines the minimum auto-increment-bit requirements.

Changes

AUTO_RANDOM documentation

Layer / File(s) Summary
Document bit-layout constraints
auto-random.md
Clarifies signed-bit behavior, implicit positive values, and minimum auto-increment-bit requirements for signed and unsigned columns.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the documentation change to AUTO_RANDOM.
Description check ✅ Passed The description covers the required change, affected versions, related issue, translated PR, and checklist fields.
Linked Issues check ✅ Passed The changes address issue #23404 by documenting positive default values and the 27-bit auto-increment limitation.
Out of Scope Changes check ✅ Passed The changes are limited to the requested AUTO_RANDOM documentation clarifications.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Comment thread auto-random.md Outdated
@qiancai

qiancai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

/cc @djshow832

@ti-chi-bot
ti-chi-bot Bot requested a review from djshow832 August 12, 2026 02:12
@qiancai qiancai self-assigned this Aug 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

@djshow832: adding LGTM is restricted to approvers and reviewers in OWNERS files.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@qiancai

qiancai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator Author

/approve

@qiancai qiancai added the lgtm label Aug 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 12, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 97bbec4 into pingcap:master Aug 12, 2026
12 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-6.5: #23499.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #23500.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #23501.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #23502.

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #23503.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enhance the claim of auto random type limitation

3 participants