Skip to content

Add more description to AUTO_RANDOM (#23498) - #23503

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23498-to-release-8.5
Aug 12, 2026
Merged

Add more description to AUTO_RANDOM (#23498)#23503
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-23498-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Aug 12, 2026

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #23498

What is changed, added or deleted? (Required)

close #23404

Add 2 more descriptions:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)

What is the related PR or file link(s)?

AI agent involvement

  • The changes in this PR were primarily made by an AI agent on behalf of the PR author.

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

Summary by CodeRabbit

  • Documentation
    • Clarified how signed-bit handling depends on UNSIGNED.
    • Documented that automatically generated signed values use a zero sign bit, while explicitly inserted values are exempt.
    • Added minimum bit requirements and separate sizing formulas for signed and unsigned auto-increment columns.

@ti-chi-bot ti-chi-bot added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Aug 12, 2026
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The AUTO_RANDOM documentation now clarifies signed-bit behavior, positivity for implicitly generated values, explicit-value exceptions, and minimum auto-increment-bit formulas for signed and unsigned columns.

Changes

Auto-random bit-layout documentation

Layer / File(s) Summary
Clarify auto-random bit requirements
auto-random.md
Documents signed-bit behavior based on UNSIGNED, positivity for implicitly generated values, the exception for explicit values, and the minimum auto-increment-bit formulas.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • pingcap/docs#23498: Updates the same documentation with related signed/unsigned bit-layout clarifications.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the documentation update for AUTO_RANDOM.
Description check ✅ Passed The description covers the changes, affected versions, related links, and required checklist sections.
Linked Issues check ✅ Passed The documentation adds the requested AUTO_RANDOM positivity behavior and minimum auto-increment-bit limitation from issue #23404.
Out of Scope Changes check ✅ Passed The changes are limited to clarifying AUTO_RANDOM documentation requirements from issue #23404.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 19e18daa-c931-4cb6-a568-7c7df570a9a1

📥 Commits

Reviewing files that changed from the base of the PR and between b5b0a64 and 83d22fd.

📒 Files selected for processing (1)
  • auto-random.md

Comment thread auto-random.md
@qiancai

qiancai commented Aug 12, 2026

Copy link
Copy Markdown
Collaborator

/approve

@ti-chi-bot

ti-chi-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Aug 12, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 242e6b6 into pingcap:release-8.5 Aug 12, 2026
12 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-23498-to-release-8.5 branch August 12, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants