Skip to content

kafka: upgrade Sarama to v1.61.1 to fix message ordering - #6514

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
3AceShowHand:bump-sarama-1.61.1
Oct 12, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:masterfrom
3AceShowHand:bump-sarama-1.61.1

Conversation

@3AceShowHand

@3AceShowHand 3AceShowHand commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #6515

What is changed and how it works?

Upgrade Sarama from v1.61.0 to v1.61.1 to fix message ordering during retries.

Check List

Tests

  • Manual test: retry-ordering reproducer passed 3 times with -race on v1.61.1.

Release note

bump sarama to v1.61.1

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 12 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: f1a297cb-9fca-4959-9af9-2875ec156218

📥 Commits

Reviewing files that changed from the base of the PR and between 61ff123 and 870ac6e.


⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum

📒 Files selected for processing (1)
  • go.mod

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ti-chi-bot ti-chi-bot Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 12, 2026
@3AceShowHand 3AceShowHand changed the title bump sarama to v1.61.1 kafka: upgrade Sarama to v1.61.1 to fix message ordering Oct 12, 2026
@3AceShowHand 3AceShowHand added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-nextgen-202609 Should cherry pick this PR to release-nextgen-202609 branch. and removed do-not-merge/needs-triage-completed labels Oct 12, 2026
@3AceShowHand

Copy link
Copy Markdown
Collaborator Author

/test all

@3AceShowHand

Copy link
Copy Markdown
Collaborator Author

/check-issue-triage-complete

@3AceShowHand

Copy link
Copy Markdown
Collaborator Author

/test all

@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Oct 12, 2026
@ti-chi-bot ti-chi-bot Bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 12, 2026
@ti-chi-bot

ti-chi-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

[LGTM Timeline notifier]

Timeline:

  • 2026-10-12 10:00:25.904656967 +0000 UTC m=+638835.651887816: ☑️ agreed by wk989898.
  • 2026-10-12 10:41:47.020961273 +0000 UTC m=+641316.768192112: ☑️ agreed by asddongmen.

@3AceShowHand

Copy link
Copy Markdown
Collaborator Author

/retest

@ti-chi-bot

ti-chi-bot Bot commented Oct 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asddongmen, lidezhu, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [asddongmen,lidezhu,wk989898]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
ti-chi-bot Bot merged commit 1e9d471 into pingcap:master Oct 12, 2026
40 checks passed
@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #6517.
But this PR has conflicts, please resolve them!

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-nextgen-202609: #6518.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. needs-cherry-pick-release-nextgen-202609 Should cherry pick this PR to release-nextgen-202609 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

kafka: messages can be produced out of order during retries

5 participants