Repository navigation
Fix declaration order after @at-root - #181
Open
wozhenbang2004 wants to merge 1 commit into
Open
wozhenbang2004 wants to merge 1 commit into
wozhenbang2004 wants to merge 1 commit into
Conversation
Member
|
Can you show input, before and after exampes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declarations after
@at-rootare currently emitted in the original parent rule, ahead of the rule that@at-roothoists. If both rules set the same property on the same selector, this can reverse the cascade.Reuse the existing declaration handling for hoisted rules so later declarations are emitted after
@at-root. Both shorthand and block regressions fail on the unmodified implementation.pnpm testpasses all 81 tests with the fix.