Skip to content

Fix declaration order after @at-root #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wozhenbang2004 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix declaration order after @at-root #181

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,6 +424,7 @@ let nested = (opts = {}) => {
)

if (child.name === rootRuleName) {
copyDeclarations = true
unwrapped = true
atruleChilds(rule, child, true, child[ROOT_RULE_MERGE_SEL])
after = breakOut(child, after)
Expand Down
14 changes: 14 additions & 0 deletions index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ test('at-root short hand', () => {
run('a { & {} @at-root b { } }', 'a {} b {}')
})

test('keeps declarations after at-root shorthand in source order', () => {
run(
'a { color: red; @at-root a { color: blue; } color: green; }',
'a { color: red; } a { color: blue; } a { color: green; }'
)
})

test('keeps declarations after an at-root block in source order', () => {
run(
'a { color: red; @at-root { a { color: blue; } } color: green; }',
'a { color: red; } a { color: blue; } a { color: green; }'
)
})

test('hoists multiple at-roots', () => {
run(
`a {
Expand Down
Loading