Repository navigation
feat: taskbar strip side and offset, clear of Start, Widgets and apps (#4) - #12
Merged
Merged
Conversation
Windows 11 draws those buttons with XAML, so the strip couldn't see them: on a left-aligned taskbar Left covered Start, and Widgets sat under the strip on either side. A UI Automation thread now measures the buttons every second and the strip keeps to the gaps between them. The second position follows the Windows icon alignment: Left when centered, Center when left. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KHc1HaoK4c5kUmgtCmKuwT
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Claude reviewCommit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ElliotDrel's #4 (taskbar strip side and offset), with its commits unchanged, plus one commit on top. AI review skips pull requests from forks, so it runs here; merging this marks #4 as merged too.
From #4: Left/Right placement and an Offset (px) control for the taskbar strip.
Added here: in a real test on Windows 11, Left covered Start on a left-aligned taskbar, and Widgets (the weather button) sat under the strip on either side, including the default Right position once Widgets move next to the tray. Windows 11 draws Start, Widgets and the app buttons with XAML, so the strip had no windows to measure. Now:
taskbar_strip/uia.rsmeasures the taskbar's buttons with UI Automation once a second, on its own thread (those calls wait on Explorer; the strip thread shares Explorer's input queue and must not block). One cachedFindAllBuildCacheper taskbar, a few ms.placement.rskeeps the strip in the gaps between them: Right = the gap next to the tray, Left = the leftmost gap, and when Windows aligns the icons left (TaskbarAl= 0) the second position becomes Center: the taskbar's middle, pushed right once the apps reach it. No gap wide enough: hidden, as before.Tested live on this machine: centered icons with and without Widgets, left-aligned icons with Widgets beside the tray, Right and Center. After a Windows alignment change the strip can overlap for a second or two until the next measurement.
Checks:
bunx tsc --noEmit,bun run test(1286 passed),cargo test --locked --lib(218 passed).🤖 Generated with Claude Code
https://claude.ai/code/session_01KHc1HaoK4c5kUmgtCmKuwT