Repository navigation
Port upstream pstack 0.15.28 - #19
Conversation
Bring in #721, #716, and #724: TLA+ default and no-verifier fallback, maintain-formal-verification-skill, and the 0.15.28 version bump. Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same account as author).
diff is clean. every +/- line matches upstream f9be7aa00..d45756733 for pstack/ (#721, #716, #724): guide 06/09, create-formal-verification-skill, the new maintain-formal-verification-skill (verbatim, frontmatter kept), poteto-help + recipes. both manifests and the readme pin say 0.15.28, cursor-team-kit stays 1.2.0. skipping the upstream readme skill-table row is fine, this readme doesn't carry that table. no issue to link.
blocking on one thing: harness proof. please add, in the body or a comment, real output on head 8e8a339 of:
agy plugin installfrom this branchagy plugin listshowing pstack 0.15.28- the changed skills exercised:
/maintain-formal-verification-skillregistered and loadable, plus/create-formal-verification-skilland/poteto-helpshowing the new text from the installed copy
if a live model turn is blocked only by cli auth, install + list on the exact head plus the installed copy showing the changed skills is enough for these text-only changes. ci (Validate plugin) was still running when i looked; it needs to be green too.
|
Harness proof on head Installed copy is that commit, not the workspace tree:
CI on No code changes. Not merged. |
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (comment review, same account as author). not merging yet.
re-reviewed on head 8e8a33940e230e0fe4694efd1a01bce0f35d5b48 (unchanged). most of the proof in #19 (comment) holds:
- real
agy1.4.2 output:agy plugin installfrom the branch url, thenagy plugin listshowspstack (enabled, 0.15.28), 59 skills, 2 agents. git rev-parse HEADin the installed copy is8e8a33940e230e0fe4694efd1a01bce0f35d5b48, so the install is the exact head.maintain-formal-verification-skill,create-formal-verification-skill, andpoteto-helpare inagy plugin list --json, and the installed copy shows the new text in all three (plus recipes.md).- ci
Validate pluginis green on the head.
one gap: no live model turn was run against any changed skill, and the proof doesn't say why. the installed-copy fallback is only for when a live turn is blocked by cli auth. please do one of these:
- run a live
agyturn on this install that uses a changed skill (for example/poteto-helpasked about keeping a formal verification in sync, so it points at/maintain-formal-verification-skill, or/maintain-formal-verification-skillloading and stopping at "no verify skill" in an empty repo), and paste the real output; or - if a live turn is blocked only by cli auth, paste the actual auth error output from the attempt.
either one on head 8e8a339 and this is approved.
|
Live The plugin from the earlier install is still that commit ( Tiny fixture: a new git repo with one file, Exit code: That is why there is no live turn: |
caelaxie
left a comment
There was a problem hiding this comment.
approved under the auth-block precedent.
this closes the gap from pullrequestreview-5579801175 (no live turn, no reason given). #issuecomment-6281321938 shows a live turn attempt on the installed head 8e8a33940e230e0fe4694efd1a01bce0f35d5b48. the installed plugin's git rev-parse HEAD is that sha, and agy plugin list shows pstack (enabled, 0.15.28). it ran the real command agy --print-timeout 45s --dangerously-skip-permissions --print '/maintain-formal-verification-skill' against a tiny fixture with the install HOME. that is a skill this pr adds. the turn stopped at google oauth with the verbatim Error: authentication timed out. / error: authentication failed or timed out, exit 1, empty stdout, before the skill was invoked.
the rest is already verified on this head: the diff matches upstream, versions are 0.15.28, install + list show 0.15.28 at this rev, the installed copy has the changed text for maintain-/create-formal-verification-skill and poteto-help, and ci (validate plugin) is green. this pr only changes skill text, so install+list on the exact head plus the installed changed skills is accepted when cli auth is the only thing blocking the live turn. squash-merging pinned to 8e8a339.
summary
ports upstream cursor/plugins pstack after
f9be7aa00(#715, pstack 0.15.27) through0.15.28. cursor-team-kit stays1.2.0.git log f9be7aa00..origin/main -- pstack/ cursor-team-kit/is exactly the three commits below.ported
#7216b78e9f4etla+ default and no-verifier fallback in/create-formal-verification-skill#7167b353f78fadd/maintain-formal-verification-skill#724d45756733bump to0.15.28, sync the guide with create-formal-verification-skillguide and skill text is copied verbatim. the new skill has no cursor-only paths, so it is unchanged. files this port already adapts keep those adaptations (install paths, model tiers,
invoke_subagentworkspaces, bundled/deslop,/goalinstead of/loop). the verify-skill path stays.agents/skills/.skipped
pstack/README.mdskill-table row for/maintain-formal-verification-skill. this readme is the antigravity install page and does not carry that table. the version pin here is0.15.28.harness proof
agy1.4.2, installed from the antigravity cli installer. commands ran against this branch checkout with a cleanHOME.agy plugin list --jsonlistsmaintain-formal-verification-skillandcreate-formal-verification-skill. all 59 installed skills have frontmatternameequal to the directory. the installedcreate-formal-verification-skillcontains "TLA+ is the default for that in any language", "test the real code with generated inputs, not a hand model of the function", and "point the user at/maintain-formal-verification-skill". the installedmaintain-formal-verification-skillis that folder name and contains "whether each failure is drift in the verification or a bug in the code".the ci workflow on this pr passed: validate plugin, 59 skills, script typecheck, and tests.