Repository navigation
Support agy 1.4+ native file tool names and clarify tier vs inherit effort - #20
Merged
Merged
Conversation
caelaxie
commented
Oct 20, 2026
caelaxie
left a comment
Collaborator
Author
There was a problem hiding this comment.
verdict: changes requested (posted as comment since author and reviewer share an account).
scope is fine. every touched line is already an agy-only adaptation (upstream says Task/model slugs there), and the edits only pair the 1.4 cli names with the ide names plus the tier vs inherit note. ci green. no issue to link, ok.
blocking:
- half-ported tool names.
agents/poteto-agent.mdandagents/comment-sicko.mdstill list onlyview_file,write_to_file,replace_file_content,multi_replace_file_contentundertools:. if the 1.4 cli only exposesread_file/write_file/edit_file, apoteto-agentsubagent there gets no file tools. either add the three names to both agents'tools:lists (that's the only consumer of the ci allowlist change), or drop the ci.yml additions. as is, the allowlist change is dead. - no harness proof.
agy plugin validateand the bun tests aren't the harness. needagy plugin install+agy plugin liston head c2cc7c0 (or the new head), plus the changed skills exercised: ideally an agy 1.4 cli turn showing a pstack skill read viaread_fileand apoteto-agentspawn that can read/write. if the live turn is auth-blocked, install + list plus the installed copy showing the changed lines is the accepted fallback, with the verbatim auth error.
re-review when proof lands in the body or a comment.
|
|
||
| const validAgentTools = new Set([ | ||
| "send_message", | ||
| "read_file", |
Collaborator
Author
There was a problem hiding this comment.
nothing in the repo uses read_file/write_file/edit_file in an agent tools: list yet, so this allowlist entry is dead. either wire them into agents/poteto-agent.md and agents/comment-sicko.md (needed if 1.4 cli subagents only get the new names) or drop these three lines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses two minor compatibility quirks with
agy1.4+ (use-component-rewriteenabled):CLI vs IDE file tool names (
read_file/write_file/edit_file)agy1.4+ CLI,buildDefaultAgent(third_party/jetski/cortex/core/components/config/agent_config.go) exposesread_file,write_file, andedit_fileon the main agent andTypeName: "self"subagents (and logs"name":"read_file"intotranscript.jsonl), while Antigravity IDE and legacy step handlers exposeview_file,write_to_file, andreplace_file_content/multi_replace_file_content.poteto-mode,figure-it-out,swarm,architect,arena,interrogate,how,why,reflect) to name bothread_file/view_fileandwrite_file/write_to_file, including/reflect's transcript skill-usage detection.read_file,write_file, andedit_filetovalidAgentToolsin.github/workflows/ci.yml.Modeltier (pro/flash/flash_lite) vsinheritreasoning effort(*InvokeSubagentTool).resolveModel(third_party/jetski/cortex/core/tools/invoke_subagent.go), passingpro,flash, orflash_literesolves to the backend's default model and default reasoning effort for that tier (TieredModelConfig.GetPro()[0], etc.), whereasinherit(and thepstack-models.mdaliasesinherit-parentandauto) clones the parent conversation'sPlanModel, preserving its exact model family and reasoning effort.skills/setup-pstack/SKILL.mdandskills/poteto-mode/SKILL.md.Verification
agy plugin validate ..github/workflows/ci.ymlmanifest, skill, agent, and playbook index checksbun run typecheckandbun run testinskills/poteto-mode/scripts(69/69 tests passing)