Skip to content

Support agy 1.4+ native file tool names and clarify tier vs inherit effort - #20

Merged
caelaxie merged 1 commit into
mainfrom
fix/cli-tool-names-and-tier-effort
Oct 20, 2026
Merged

caelaxie merged 1 commit into
mainfrom
fix/cli-tool-names-and-tier-effort

Conversation

@caelaxie

Copy link
Copy Markdown
Collaborator

Summary

Addresses two minor compatibility quirks with agy 1.4+ (use-component-rewrite enabled):

  1. CLI vs IDE file tool names (read_file / write_file / edit_file)

    • In agy 1.4+ CLI, buildDefaultAgent (third_party/jetski/cortex/core/components/config/agent_config.go) exposes read_file, write_file, and edit_file on the main agent and TypeName: "self" subagents (and logs "name":"read_file" into transcript.jsonl), while Antigravity IDE and legacy step handlers expose view_file, write_to_file, and replace_file_content / multi_replace_file_content.
    • Updated skill instructions and reference prompts (poteto-mode, figure-it-out, swarm, architect, arena, interrogate, how, why, reflect) to name both read_file / view_file and write_file / write_to_file, including /reflect's transcript skill-usage detection.
    • Added read_file, write_file, and edit_file to validAgentTools in .github/workflows/ci.yml.
  2. Model tier (pro / flash / flash_lite) vs inherit reasoning effort

    • In (*InvokeSubagentTool).resolveModel (third_party/jetski/cortex/core/tools/invoke_subagent.go), passing pro, flash, or flash_lite resolves to the backend's default model and default reasoning effort for that tier (TieredModelConfig.GetPro()[0], etc.), whereas inherit (and the pstack-models.md aliases inherit-parent and auto) clones the parent conversation's PlanModel, preserving its exact model family and reasoning effort.
    • Documented this distinction in skills/setup-pstack/SKILL.md and skills/poteto-mode/SKILL.md.

Verification

  • agy plugin validate .
  • Full .github/workflows/ci.yml manifest, skill, agent, and playbook index checks
  • bun run typecheck and bun run test in skills/poteto-mode/scripts (69/69 tests passing)

@caelaxie caelaxie left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verdict: changes requested (posted as comment since author and reviewer share an account).

scope is fine. every touched line is already an agy-only adaptation (upstream says Task/model slugs there), and the edits only pair the 1.4 cli names with the ide names plus the tier vs inherit note. ci green. no issue to link, ok.

blocking:

  1. half-ported tool names. agents/poteto-agent.md and agents/comment-sicko.md still list only view_file, write_to_file, replace_file_content, multi_replace_file_content under tools:. if the 1.4 cli only exposes read_file/write_file/edit_file, a poteto-agent subagent there gets no file tools. either add the three names to both agents' tools: lists (that's the only consumer of the ci allowlist change), or drop the ci.yml additions. as is, the allowlist change is dead.
  2. no harness proof. agy plugin validate and the bun tests aren't the harness. need agy plugin install + agy plugin list on head c2cc7c0 (or the new head), plus the changed skills exercised: ideally an agy 1.4 cli turn showing a pstack skill read via read_file and a poteto-agent spawn that can read/write. if the live turn is auth-blocked, install + list plus the installed copy showing the changed lines is the accepted fallback, with the verbatim auth error.

re-review when proof lands in the body or a comment.

Comment thread .github/workflows/ci.yml

const validAgentTools = new Set([
"send_message",
"read_file",

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing in the repo uses read_file/write_file/edit_file in an agent tools: list yet, so this allowlist entry is dead. either wire them into agents/poteto-agent.md and agents/comment-sicko.md (needed if 1.4 cli subagents only get the new names) or drop these three lines.

@caelaxie
caelaxie merged commit 8bb2167 into main Oct 20, 2026
1 check passed
@caelaxie
caelaxie deleted the fix/cli-tool-names-and-tier-effort branch October 20, 2026 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant