Repository navigation
port pstack 0.15.27 (#692, #708, #709, #710, #712, #713, #715) - #6
Conversation
Co-authored-by: Kaitian Xie <caelaxie@users.noreply.github.com>
caelaxie
left a comment
There was a problem hiding this comment.
verdict: changes requested (posted as comment, same account authored this).
content is clean. diffed every file against upstream 019a6a20...f9be7aa0 (pstack/):
- 13 of 15 files match upstream's diff line for line.
docs/guide/06-verify-and-ship.mddiffers only in.grok/skills/verify-<app>/, same adaptation as before.skills/poteto-help/SKILL.mddrops upstream's "Other tools can read the skills…" paragraph in favor of the existing grok build paragraph; claude code paragraph is verbatim. ok.- README only bumps
0.15.25->0.15.27; skipping the skill-table rows matches the short port readme.plugin.json0.15.27 matches upstream. cursor-team-kit has no commits in range, stays 1.2.0. - ci green, no issue to link.
blocking: harness proof is still "Pending". need on this head:
grok plugin install <branch checkout> --trustandgrok plugin listoutput showing pstack 0.15.27.- changed skills exercised in grok: at least
/create-formal-verification-skillloads (it's new anddisable-model-invocation: true), and/ketchup,/sharpen,/setup-pstackstep 8 render the new text from the installed copy.
add it to the body or a comment and i'll re-review and merge.
| @@ -0,0 +1,41 @@ | |||
| --- | |||
There was a problem hiding this comment.
new skill: show it loading from the installed plugin in grok (invoked by /create-formal-verification-skill, since model invocation is off). part of the harness proof.
|
Harness proof. grok 1.0.62, branch
A model turn did not run. |
caelaxie
left a comment
There was a problem hiding this comment.
verdict: approved (posted as comment, same account authored this).
harness proof checks out on head 32fd02c (comment, mirrored in the body):
- grok 1.0.62,
grok plugin install https://github.com/pstack-ports/grok-pstack@cursor/port-pstack-0.15.27-d8db --trustinstalled pstack. grok plugin list --json/plugin detailsshow pstack 0.15.27, andgit rev-parse HEADin the installed checkout is32fd02cdbdcb5e4cdc9cd9e8b8f7d9441dc4c748, the PR head.grok inspectresolvescreate-formal-verification-skill,ketchup,sharpen,setup-pstack,poteto-helpfromplugin=pstackwith the new descriptions; installed copies carry the ketchup "never cut items" line, no rewritten-prompt ban in sharpen, setup-pstack step 8.- no live model turn: CLI not signed in. per grok-pstack #5, inspect loading the changed skills counts as exercise when auth is the only blocker.
content was already verified (13/15 verbatim, 2 declared grok adaptations), Validate plugin still green on 32fd02c, no issue to link. squash-merging pinned to 32fd02c.
|
Harness proof for head
Installed path: ketchup ( sharpen ( setup-pstack step 8 ( |
Port upstream
pstack/from019a6a20(#704) throughf9be7aa0(#715). Version goes from 0.15.25 to 0.15.27. cursor-team-kit stays 1.2.0. The short port README only changes the version.Upstream commits
16541c6b/ #692 — list every waiting item so each ketchup call is decidablebc144379/ #708 — say outright that ketchup never cuts items to stay under a word count4382e687/ #709 — add/create-formal-verification-skill0b8e9520/ #710 — bump to 0.15.2675fabace/ #712 — drop the rewritten-prompt ban from sharpen0148b78c/ #713 — bump to 0.15.27f9be7aa0/ #715 — offer formal verification in setup, sync help and guidecursor-team-kit/has no commits after019a6a20. No.cursor-plugin/plugin.json(same as earlier port PRs). README skill-table lines from upstream are not applied.Grok adaptations
New upstream text is copied verbatim, except:
docs/guide/06-verify-and-ship.mdkeeps.grok/skills/verify-<app>/where upstream says.cursor/skills/verify-<app>/.skills/poteto-help/SKILL.mdkeeps the existing Grok Build paragraph in place of upstream's "Other tools can read the skills… spawn Cursor subagents…" paragraph. The new Claude Code install paragraph is included verbatim, becausedocs/harness/claude-code.mdis already in this port.plugin.jsonis bumped to0.15.27. Upstream's.cursor-plugin/plugin.jsonbump is not copied. This port has no Cursor plugin manifest.Existing spawn and skill wording in the touched files stays:
spawn_subagent,subagent_type: "pstack:poteto-agent",isolation: "worktree",.grokpaths, bundleddeslop/control-cli/control-ui, no custom mode, and the Grok model slugs in/setup-pstack.CI
Validate plugin succeeded on
32fd02c. It reportedValidated 58 skills, 2 agents, and 23 playbooksandRan 68 tests across 5 files.Harness proof
grok 1.0.62, on
cursor/port-pstack-0.15.27-d8dbat32fd02cdbdcb5e4cdc9cd9e8b8f7d9441dc4c748.grok inspectloads 58 skills from plugin pstack (57 before this port, pluscreate-formal-verification-skill). ketchup, sharpen, setup-pstack, and poteto-help resolve under those names with the new descriptions. The installed tree has ketchup's "Never cut items" line, no "rewritten prompt" ban in sharpen, and setup-pstack step 8.A model turn did not run.
grok -p '/ketchup' --max-turns 1exited 1: not signed in, andXAI_API_KEYis unset.