Skip to content

[Vulkan] Require a hardware GPU in the NVIDIA Vulkan CI job - #23201

Closed
mergennachin wants to merge 1 commit into
mainfrom
mergennachin/vulkan-23156-01-ci-hardware
Closed

mergennachin wants to merge 1 commit into
mainfrom
mergennachin/vulkan-23156-01-ci-hardware

Conversation

@mergennachin

@mergennachin mergennachin commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Superseded by #23240, part 1/15 of the ghstack replacement series. The current integration PR is #23254. This PR is closed in favor of the replacement; its previous description and review history are retained.


The real-GPU Vulkan job silently fell back to SwiftShader whenever the NVIDIA ICD failed to enumerate, so 8-bit storage buffer paths and the custom-op benchmarks could pass without touching the GPU. setup-vulkan-linux-deps.sh now prefers the NVIDIA EGL ICD, installs its EGL and X11 client dependencies, and fails with ldd diagnostics instead of falling back when real-gpu is requested. test_backend.sh always requests SwiftShader, since CPU runners can ship Mesa ICDs without a usable device.

Part 1/15 of the Vulkan transformer and operator-conformance stack. This enables hardware validation for the following changes. Integration PR: #23162.

Validation: Both CI setup scripts pass bash -n; lintrunner and git diff --check pass. NVIDIA execution will be verified by this PR’s CI run.

Authored with OpenAI Codex; split planned with Claude Code.

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

The real-GPU Vulkan job silently fell back to SwiftShader whenever the NVIDIA ICD failed to enumerate, so 8-bit storage buffer paths and the custom-op benchmarks could pass without touching the GPU. setup-vulkan-linux-deps.sh now prefers the NVIDIA EGL ICD, installs its EGL and X11 client dependencies, and fails with ldd diagnostics instead of falling back when real-gpu is requested. test_backend.sh always requests SwiftShader, since CPU runners can ship Mesa ICDs without a usable device.

Authored with OpenAI Codex; split planned with Claude Code.
@pytorch-bot pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Sep 28, 2026
@pytorch-bot

pytorch-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23201

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 37 Pending

As of commit 2fc9384 with merge base a318382 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 28, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This branch was successfully deployed

1 active deployment
cadence — 2fc93842 Deployed Sep 28, 2026 by mergennachin via hifi-op-test / hifi4 #30178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant