Skip to content

Pin ROCm TorchAO nightly separately to unbreak ROCm CI - #23264

Merged
Gasoonjia merged 1 commit into
mainfrom
gasoonjia/rocm-torchao-pin
Sep 30, 2026
Merged

Gasoonjia merged 1 commit into
mainfrom
gasoonjia/rocm-torchao-pin

Conversation

@Gasoonjia

Copy link
Copy Markdown
Contributor

Summary

Since #23184, every run of unittest-rocm-gfx950-rocm7.2 and test-voxtral-realtime-rocm-gfx950-rocm7.2 on main fails while installing TorchAO:

ERROR: HTTP error 403 while getting https://download.pytorch.org/whl/nightly/rocm7.2/torchao-0.19.0.dev20260907%2Brocm7.2-cp310-abi3-manylinux_2_28_x86_64.whl

(Green ROCm workflow runs on HUD since then are runs where the path filter skipped these jobs.)

Both ROCm scripts build the wheel URL from TORCHAO_NIGHTLY_VERSION, but 0.19.0.dev20260907 has no rocm7.2 build. On the rocm7.2 nightly index, the last cp310-abi3 (compiled-kernel) wheel is 0.19.0.dev20260805; later ROCm nightlies are py3-none-any only, and nothing is published after 0.19.0.dev20260831.

Changes:

  • Add ROCM_TORCHAO_NIGHTLY_VERSION = "0.19.0.dev20260805" in install_requirements.py and use it in both ROCm scripts.
  • The voxtral job does a full (non-minimal) ExecuTorch install, whose torchao>=0.19.0.dev20260907,<0.20 requirement would otherwise make pip try to replace the ROCm wheel. Install ExecuTorch with --no-deps, then install its declared dependencies except torchao. The AOTI job uses EXECUTORCH_BUILD_MINIMAL=1, which has no torchao dependency, so it only needs the pin change.

Follow-up: switch ROCm back to TORCHAO_NIGHTLY_VERSION once TorchAO publishes rocm7.2 nightlies again.

Test plan

  • Verified via ranged GET that torchao-0.19.0.dev20260805+rocm7.2-cp310-abi3-manylinux_2_28_x86_64.whl is downloadable and 0.19.0.dev20260907+rocm7.2 is not.
  • bash -n on both scripts; checked the dependency filter locally (drops torchao and non-matching markers/extras).
  • ROCm workflow CI on this PR.

#23184 bumped TORCHAO_NIGHTLY_VERSION to 0.19.0.dev20260907, which has no
rocm7.2 build, so both ROCm jobs fail with a 403 when fetching the TorchAO
wheel. Pin ROCm to 0.19.0.dev20260805, the newest rocm7.2 nightly with
compiled kernels, and keep the voxtral job's full ExecuTorch install from
trying to satisfy the torchao>=0.19.0.dev20260907 bound.
@pytorch-bot

pytorch-bot Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23264

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 3 Unrelated Failures

As of commit 6389b0b with merge base 96c621d (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 29, 2026
@github-actions

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@Gasoonjia
Gasoonjia merged commit 53c79ed into main Sep 30, 2026
490 of 501 checks passed
@Gasoonjia
Gasoonjia deleted the gasoonjia/rocm-torchao-pin branch September 30, 2026 07:48

This branch was successfully deployed

1 active deployment
cadence — 6389b0b2 Deployed Sep 29, 2026 by Gasoonjia via hifi-op-test / hifi4 #30500
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/cuda ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants