Skip to content

Pin ROCm TorchAO nightly separately to unbreak ROCm CI #23264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gasoonjia merged 1 commit into from
Sep 30, 2026
+23 −5
Merged

Pin ROCm TorchAO nightly separately to unbreak ROCm CI #23264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .ci/scripts/test-rocm-aoti.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ export TORCHINDUCTOR_COMPILE_THREADS=1

read -r TORCH_VERSION TORCHAO_VERSION < <(
python - <<'PY'
from install_requirements import TORCHAO_NIGHTLY_VERSION
from install_requirements import ROCM_TORCHAO_NIGHTLY_VERSION
from torch_pin import TORCH_VERSION

print(TORCH_VERSION, TORCHAO_NIGHTLY_VERSION)
print(TORCH_VERSION, ROCM_TORCHAO_NIGHTLY_VERSION)
PY
)
# TorchAO ROCm wheels are not exposed by the per-version pip index.
Expand Down
21 changes: 18 additions & 3 deletions .ci/scripts/test-rocm-voxtral.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ export HF_TOKEN

read -r TORCH_VERSION TORCHAO_VERSION < <(
python - <<'PY'
from install_requirements import TORCHAO_NIGHTLY_VERSION
from install_requirements import ROCM_TORCHAO_NIGHTLY_VERSION
from torch_pin import TORCH_VERSION

print(TORCH_VERSION, TORCHAO_NIGHTLY_VERSION)
print(TORCH_VERSION, ROCM_TORCHAO_NIGHTLY_VERSION)
PY
)
# TorchAO ROCm wheels are not exposed by the per-version pip index.
Expand All @@ -48,7 +48,22 @@ python -m pip install "torch==${TORCH_VERSION}" \
--index-url "${PYTORCH_ROCM_INDEX}"
python -m pip install -r requirements-dev.txt \
"${TORCHAO_WHEEL}"
python -m pip install --editable . --no-build-isolation
# ExecuTorch requires torchao>=TORCHAO_NIGHTLY_VERSION, which has no ROCm build, so
# install its other dependencies separately to keep the ROCm TorchAO wheel in place.
python -m pip install --editable . --no-build-isolation --no-deps
python - <<'PY' >"${VOXTRAL_CI_TMPDIR}/executorch-deps.txt"
from importlib.metadata import requires

from packaging.requirements import Requirement

for spec in requires("executorch") or []:
req = Requirement(spec)
if req.name == "torchao":
continue
if req.marker is None or req.marker.evaluate({"extra": ""}):
print(spec)
PY
python -m pip install -r "${VOXTRAL_CI_TMPDIR}/executorch-deps.txt"

if ! command -v conda >/dev/null; then
echo "The ROCm CI image must provide conda for its runtime libraries"
Expand Down
3 changes: 3 additions & 0 deletions install_requirements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
TORCHAO_URL_BASE = "https://download.pytorch.org/whl/nightly"
TORCHAO_NIGHTLY_VERSION = "0.19.0.dev20260907"
CU134_TORCHAO_NIGHTLY_VERSION = "0.19.0.dev20260907"
# Newest rocm7.2 TorchAO nightly with compiled kernels (cp310-abi3); later ROCm nightlies
# are py3-none-any only, and none are published after 0.19.0.dev20260831.
ROCM_TORCHAO_NIGHTLY_VERSION = "0.19.0.dev20260805"
# These wheels' metadata pairs August 11 domain libraries with August 10 torch.
CU134_TORCH_PACKAGES = [
"torch==2.14.0.dev20260810+cu134",
Expand Down
Loading