feat(sdk): show a consent tooltip and add a disableIntent prop - #1925
Conversation
While the consent checkbox is unchecked, hovering the disabled OIDC button or either "Continue with Email" button in the sign-up view shows "You must agree to continue", anchored to the top-end of the button. Claude-Session: https://claude.ai/code/session_01SwGUtD3mDrTjM1rLWnxrnA
Only the submit button is blocked until the consent checkbox is checked, so the input keeps its normal appearance and the email can be typed before agreeing. Claude-Session: https://claude.ai/code/session_01SwGUtD3mDrTjM1rLWnxrnA
Return the child untouched unless the control is disabled with a message, drop the now redundant trigger and content guards, and anchor the tooltip at the top-right corner of the button. Claude-Session: https://claude.ai/code/session_01SwGUtD3mDrTjM1rLWnxrnA
When set, the views send no flow intent on the OIDC buttons and the email form, so the server keeps its create-or-get behaviour instead of gating on whether the account exists. The consent checkbox and the accepted document ids are unchanged, since consent is enforced under every intent.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 SummarySummary by CodeRabbit
WalkthroughThe change adds a reusable disabled-state tooltip. OIDC and magic-link controls use configured messages. Sign-in and sign-up views can send an unspecified flow intent instead of fixed login or signup intents. ChangesAuthentication flow updates
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Merge Risk: 🔵 Low · up to The authentication flows remain usable, but some users may receive inaccessible, misplaced, or misleading consent guidance from disabled controls. Merge is reasonable with follow-up on these bounded UI issues. 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report for CI Build 34585613579Coverage remained the same at 50.229%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Advanced
Run ID: d7c420fe-439b-42af-8c82-0899c61702a6
📒 Files selected for processing (7)
web/sdk/client/components/auth-oidc-button/auth-oidc-button.tsxweb/sdk/client/components/disabled-tooltip/disabled-tooltip.module.cssweb/sdk/client/components/disabled-tooltip/disabled-tooltip.tsxweb/sdk/client/components/disabled-tooltip/index.tsweb/sdk/client/views/auth/magic-link/magic-link-view.tsxweb/sdk/client/views/auth/sign-in/sign-in-view.tsxweb/sdk/client/views/auth/sign-up/sign-up-view.tsx
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.
Add a disabledContentMessage prop that replaces the "You must agree to continue" text shown on the disabled OIDC and email buttons while the consent checkbox is unchecked. The default copy is unchanged.
3 participants
Summary
DisabledTooltipcomponent.SignInViewandSignUpViewgain adisableIntentprop. When set, they send no flow intent so the server keeps its create-or-get behaviour instead of gating on account existence, the opt-out described in RFC 0002. Consent handling is unchanged since it is enforced under every intent.SignUpViewgains adisabledContentMessageprop that overrides the tooltip copy on the disabled sign-up buttons.