-
Notifications
You must be signed in to change notification settings - Fork 47
feat(sdk): show a consent tooltip and add a disableIntent prop #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
ce8b598
feat(sdk): show a tooltip on disabled sign-up buttons
rohanchkrabrty 6305f12
fix(sdk): keep the email input enabled while consent is pending
rohanchkrabrty 526537a
refactor(sdk): render the disabled tooltip only when active
rohanchkrabrty 2fad065
feat(sdk): add a disableIntent prop to the sign-in and sign-up views
rohanchkrabrty 7db1c99
feat(sdk): let consumers override the consent tooltip on SignUpView
rohanchkrabrty File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
web/sdk/client/components/disabled-tooltip/disabled-tooltip.module.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| .trigger { | ||
| display: flex; | ||
| width: 100%; | ||
| } |
35 changes: 35 additions & 0 deletions
35
web/sdk/client/components/disabled-tooltip/disabled-tooltip.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { Tooltip } from '@raystack/apsara'; | ||
| import { ReactNode } from 'react'; | ||
| import styles from './disabled-tooltip.module.css'; | ||
|
|
||
| export type DisabledTooltipProps = { | ||
| disabled?: boolean; | ||
| message?: string; | ||
| children: ReactNode; | ||
| }; | ||
|
|
||
| export const DisabledTooltip = ({ | ||
| disabled = false, | ||
| message, | ||
| children | ||
| }: DisabledTooltipProps) => { | ||
| const active = disabled && !!message; | ||
|
|
||
| if (!active) return children; | ||
|
|
||
| return ( | ||
| <Tooltip> | ||
| <Tooltip.Trigger render={<span className={styles.trigger} />}> | ||
| {children} | ||
| </Tooltip.Trigger> | ||
| <Tooltip.Content | ||
| side="right" | ||
| align="start" | ||
| sideOffset={-40} | ||
| alignOffset={-10} | ||
|
rohanchkrabrty marked this conversation as resolved.
|
||
| > | ||
| {message} | ||
| </Tooltip.Content> | ||
| </Tooltip> | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| export { DisabledTooltip } from './disabled-tooltip'; | ||
| export type { DisabledTooltipProps } from './disabled-tooltip'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.